Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 Internal server error when visiting link for Pro Git v1 book #1782

Open
HonkingGoose opened this issue May 17, 2023 · 4 comments
Open

500 Internal server error when visiting link for Pro Git v1 book #1782

HonkingGoose opened this issue May 17, 2023 · 4 comments

Comments

@HonkingGoose
Copy link
Contributor

URL for broken page

https://git-scm.com/book/en/v1

Problem

The page linked above leads to a 500 Internal Server Error.

Operating system and browser

macOS 13, Firefox 113.0.1

Steps to reproduce

  1. Go to https://git-scm.com/book/en/v1
  2. End up at Internal server error page

Other details

The Pro Git book is on version 2 now. We should probably redirect to the landing page for the v2 book.

Related issue (filed in the wrong place):

@pedrorijo91
Copy link
Member

hey @HonkingGoose @derberg,

can you share where did you find links to book v1?

either way, it seems reasonable to redirect to some page. probably we removed the routing because v1 is really old AFAIK (i see v2 was released around 2014)

@HonkingGoose
Copy link
Contributor Author

According to the first issue there are links pointing to the v1 version of the book in the GitHub Docs. I will open a PR in the GitHub Docs repo to fix the links.

@HonkingGoose
Copy link
Contributor Author

I tried making the changes to the GitHub Docs myself, but I'm not allowed to touch the files with the bad links in it. So I'm opening an issue with GitHub Docs, so one of their maintainers can fix it. 😄

@HonkingGoose
Copy link
Contributor Author

either way, it seems reasonable to redirect to some page. probably we removed the routing because v1 is really old AFAIK (i see v2 was released around 2014)

I'll let you guys decide. Possible fixes:

  1. Do nothing, let downstream projects update their own links to broken pages
  2. Redirect v1 to v2 in-place: only change v1 to v2 in the link
  3. Redirect v1 links to a generic "homepage" for the v2 version of the book

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@pedrorijo91 @HonkingGoose and others