Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep git output #10206

Open
PeterMinin opened this issue Sep 21, 2022 · 5 comments · May be fixed by #10307
Open

Keep git output #10206

PeterMinin opened this issue Sep 21, 2022 · 5 comments · May be fixed by #10307
Labels
🚧 status: in progress Issues which have associated PRs type: feature request

Comments

@PeterMinin
Copy link

Feature description

Currently we have 2 options regarding the output printed by potentially long-running git commands, such as fetch, checkout, etc.:

  1. Keep the dialog open after completion of every such command. This may show some useful extra info, or a warning, but it slows you down when you need to do many little things and can get annoying.
  2. Dismiss the output right away. This speeds up routine operations, but it deprives the user from information that git developers thought could be useful to show.

There is a "Git command log" window, but it can't show the commands' output, as far as I can tell.

I think a middle ground would be good here: save the output for later and don't require the user to read and acknowledge it before proceeding. The log could be integrated into the existing "Git command log", but maybe it even deserves a tab of its own next to "Console" to make it easy to keep an eye on.

Environment

  • Git Extensions 3.5.4.12724
  • Build 65f01f3
  • Git 2.33.0.windows.2
  • Microsoft Windows NT 10.0.19044.0
  • .NET Framework 4.8.4515.0
  • DPI 120dpi (125% scaling)
@gerhardol
Copy link
Member

Related to #7244

@RussKie
Copy link
Member

RussKie commented Sep 22, 2022

Duplicate of #7244

@RussKie RussKie marked this as a duplicate of #7244 Sep 22, 2022
@RussKie RussKie closed this as completed Sep 22, 2022
@PeterMinin
Copy link
Author

@RussKie @gerhardol Thanks for taking a look. I agree the issue you referred to is relevant, i.e. implementing it would cover this issue, but not necessarily in the best way. I believe the focus of that request is largely on troubleshooting and thus mainly on persistence of the logs. Here, on the other hand, the focus is on normal operation, so I'd like to point out some specifics, in case you want to reconsider:

  • Persistence is not a requirement: the logs could exist only in the current session, like console output does. (I guess the title of the issue may be confusing, an edit would be welcome.)
  • The main scope is the long-running commands, ones that open a progress window. Maybe other "explicit" user commands too, but that's a second priority.
  • The UI for the user commands' logs should be at least somewhat separate from the existing log of background operations. At a minimum, I would say, a filter in the log. At a maximum, if the feature is expected to be popular enough, a tab in the main window, near the Console.

@mstv
Copy link
Member

mstv commented Sep 22, 2022

Occasionally, I close the progress dialog too quickly (my click finger is quicker than I think).
It would be good to keep that last output. Then I could activate Close Process dialog when process succeeds.

a tab in the main window, near the Console.

That would be the best compromise IMO.

@mstv mstv reopened this Sep 22, 2022
@mstv mstv changed the title Save git output in a log Keep git output Sep 22, 2022
@vbjay
Copy link
Contributor

vbjay commented Oct 22, 2022 •
edited

Occasionally, I close the progress dialog too quickly (my click finger is quicker than I think). It would be good to keep that last output. Then I could activate Close Process dialog when process succeeds.

a tab in the main window, near the Console.

That would be the best compromise IMO.

I would make sure some limit was set. Make this log a tail like command that does not crash the app because you left app running for days and the log has grown and eating working set of process.

Why not do a tail watch on a temp file we write to with a wrapped write like

echo "$(tail -1000 myscript.log)" > myscript.log

Then you would have a persisted log of most recently ran commands in the log and would be useful for debugging issues.

@mstv mstv linked a pull request Oct 29, 2022 that will close this issue
Open
@ghost ghost added the 🚧 status: in progress Issues which have associated PRs label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚧 status: in progress Issues which have associated PRs type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add control with last interactive Git outputs and traces mstv/gitextensions
5 participants
@PeterMinin @vbjay @RussKie @gerhardol @mstv