Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility in Task Lists: Level AA 1.3.5 Identify Input Purpose #299

Open
SallyMcGrath opened this issue Jan 5, 2023 · 3 comments
Open

Comments

@SallyMcGrath
Copy link

SallyMcGrath commented Jan 5, 2023

My journey of discovery brings me to you.

I am using goldmark in Hugo to display a small front end for our course and while I was testing I noticed that task lists as rendered by markdown are hitting my scores in Lighthouse. This is because the form elements do not have associated labels. The purpose of the input is not identified.

Lighthouse admonition
Relevant WCAG entry 1.3.5 Identify Input Purpose

I come to you because:

  1. I read the CommonMark spec and there are no task lists
  2. I read the Goldmark repo and they require "You should confirm your output is different from other official renderers correspond with an extension"
  3. I read your spec and here there are task lists. I can see you clearly state that "This spec does not define how the checkbox elements are interacted with" however Goldmark output is identical to yours in this case:

https://github.com/CodeYourFuture/immersive-go-course/blob/main/website/content/workbooks/workbook-0.md
https://cyf-systems.netlify.app/workbooks/workbook-0/ (not "launched" yet)

Screenshot 2023-01-05 at 09 13 01

It seems clear that it's undesirable to remove the inputs from the Accessibilty API with aria-hidden or presentation role as checkboxes have powers on GitHub. Would it be possible to wrap the inner text of li and input with a label and use implicit association? I guess there's a reason it isn't like this already, though. (I did search issues but couldn't find anything. )

I definitely don't have enough context on GFM task lists, but you all do, so I bring you this problem and ask for your help.

Thank you for GFM! It's really really useful and brilliant.

@wooorm
Copy link

wooorm commented Jan 23, 2023

@anticomputer PR does not seem to match this issue?

@wooorm
Copy link

wooorm commented Jan 24, 2023

@anticomputer Ping!

@anticomputer anticomputer reopened this Jan 24, 2023
@anticomputer
Copy link
Collaborator

anticomputer commented Jan 24, 2023

@anticomputer PR does not seem to match this issue?

Thanks for the heads up, the reference to #299 was from an upstream commit in cmark, which got confused for this one out of the upstream commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants