Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: github/codeql-action
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.4
Choose a base ref
...
head repository: github/codeql-action
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.5
Choose a head ref

Commits on Mar 7, 2022

  1. Update changelog and version after v1.1.4

    github-actions[bot] committed Mar 7, 2022
    Copy the full SHA
    d430deb View commit details
  2. 1.1.5

    github-actions[bot] committed Mar 7, 2022
    Copy the full SHA
    0e0e934 View commit details
  3. Update checked-in dependencies

    github-actions[bot] committed Mar 7, 2022
    Copy the full SHA
    c825c24 View commit details

Commits on Mar 8, 2022

  1. Merge pull request #966 from github/mergeback/v1.1.4-to-main-f5d82270

    Mergeback v1.1.4 refs/heads/v1 into main
    aeisenberg authored Mar 8, 2022
    Copy the full SHA
    d2fd19b View commit details
  2. Copy the full SHA
    111428c View commit details
  3. Add a timeout of 30 min

    For all CI jobs. Based on some eye-balling 30 minutes should be
    enough time for all jobs to complete.
    aeisenberg committed Mar 8, 2022
    Copy the full SHA
    628afae View commit details

Commits on Mar 9, 2022

  1. Merge pull request #971 from github/aeisenberg/timeouts

    Add a timeout of 30 min
    aeisenberg authored Mar 9, 2022
    Copy the full SHA
    cdf3c9d View commit details
  2. Copy the full SHA
    04d521d View commit details

Commits on Mar 10, 2022

  1. Copy the full SHA
    4e2634f View commit details

Commits on Mar 11, 2022

  1. Copy the full SHA
    480ef76 View commit details
  2. Copy the full SHA
    0b3acf6 View commit details
  3. Copy the full SHA
    8ecc1fc View commit details
  4. Merge pull request #975 from github/henrymercer/bump-ml-powered-queri…

    …es-to-0.1.0
    
    Bump ML-powered queries to v0.1.0
    henrymercer authored Mar 11, 2022
    Copy the full SHA
    e437ea1 View commit details
  5. Add name to workflow

    aeisenberg committed Mar 11, 2022
    Copy the full SHA
    e64a215 View commit details
  6. Copy the full SHA
    560edbc View commit details
  7. Merge pull request #968 from github/aeisenberg/required-checks

    Add some instructions on how to regenerate required checks
    aeisenberg authored Mar 11, 2022
    Copy the full SHA
    761da7e View commit details

Commits on Mar 14, 2022

  1. Copy the full SHA
    aeefdce View commit details
  2. Copy the full SHA
    c33cdd7 View commit details
  3. Copy the full SHA
    eb507cf View commit details
  4. Copy the full SHA
    e27fa67 View commit details
  5. Merge pull request #974 from github/cklin/pr/2.8.3

    Update default CodeQL bundle version to 2.8.3
    cklin authored Mar 14, 2022
    Copy the full SHA
    b74506c View commit details
  6. Copy the full SHA
    e61a4b9 View commit details
  7. Merge pull request #980 from github/edoardo/release-expected

    Remove runner from expected release files
    cklin authored Mar 14, 2022
    Copy the full SHA
    2190825 View commit details
  8. Copy the full SHA
    39aa619 View commit details
  9. Copy the full SHA
    ea5898d View commit details

Commits on Mar 15, 2022

  1. Merge pull request #978 from cklin/restore-ghes-compatibility

    Restore compatibility with GHES 3.1
    cklin authored Mar 15, 2022
    Copy the full SHA
    5b59d87 View commit details
  2. 1.1.5

    github-actions[bot] committed Mar 15, 2022
    Copy the full SHA
    69a58ad View commit details
  3. Merge pull request #982 from github/update-v1.1.5-5b59d878

    Merge main into v1
    cklin authored Mar 15, 2022
    Copy the full SHA
    8834766 View commit details
Showing with 238 additions and 54 deletions.
  1. +1 −0 .github/workflows/__analyze-ref-input.yml
  2. +1 −0 .github/workflows/__debug-artifacts.yml
  3. +1 −0 .github/workflows/__extractor-ram-threads.yml
  4. +1 −0 .github/workflows/__go-custom-queries.yml
  5. +1 −0 .github/workflows/__go-custom-tracing-autobuild.yml
  6. +1 −0 .github/workflows/__go-custom-tracing.yml
  7. +1 −0 .github/workflows/__javascript-source-root.yml
  8. +1 −0 .github/workflows/__multi-language-autodetect.yml
  9. +1 −0 .github/workflows/__packaging-config-inputs-js.yml
  10. +1 −0 .github/workflows/__packaging-config-js.yml
  11. +1 −0 .github/workflows/__packaging-inputs-js.yml
  12. +1 −0 .github/workflows/__remote-config.yml
  13. +1 −0 .github/workflows/__rubocop-multi-language.yml
  14. +1 −0 .github/workflows/__split-workflow.yml
  15. +1 −0 .github/workflows/__test-local-codeql.yml
  16. +1 −0 .github/workflows/__test-proxy.yml
  17. +1 −0 .github/workflows/__test-ruby.yml
  18. +1 −0 .github/workflows/__unset-environment.yml
  19. +1 −0 .github/workflows/__upload-ref-sha-input.yml
  20. +1 −1 .github/workflows/check-expected-release-files.yml
  21. +16 −0 .github/workflows/pr-checks.yml
  22. +1 −0 .github/workflows/python-deps.yml
  23. +1 −0 .github/workflows/release-runner.yml
  24. +1 −0 .github/workflows/split.yml
  25. +1 −0 .github/workflows/update-dependencies.yml
  26. +1 −0 .github/workflows/update-release-branch.yml
  27. +2 −0 .github/workflows/update-supported-enterprise-server-versions.yml
  28. +9 −1 CHANGELOG.md
  29. +20 −1 CONTRIBUTING.md
  30. +12 −2 lib/actions-util.js
  31. +1 −1 lib/actions-util.js.map
  32. +28 −6 lib/api-client.js
  33. +1 −1 lib/api-client.js.map
  34. +2 −2 lib/config-utils.test.js
  35. +1 −1 lib/defaults.json
  36. +2 −1 lib/init-action.js
  37. +1 −1 lib/init-action.js.map
  38. +2 −1 lib/upload-sarif-action.js
  39. +1 −1 lib/upload-sarif-action.js.map
  40. +7 −2 lib/util.js
  41. +1 −1 lib/util.js.map
  42. +7 −0 lib/util.test.js
  43. +1 −1 lib/util.test.js.map
  44. +1 −1 node_modules/.package-lock.json
  45. +2 −2 package-lock.json
  46. +2 −2 package.json
  47. +1 −0 pr-checks/sync.py
  48. +1 −1 runner/package-lock.json
  49. +2 −2 runner/package.json
  50. +15 −3 src/actions-util.ts
  51. +29 −6 src/api-client.ts
  52. +2 −2 src/config-utils.test.ts
  53. +1 −1 src/defaults.json
  54. +2 −2 src/init-action.ts
  55. +3 −7 src/upload-sarif-action.ts
  56. +27 −0 src/util.test.ts
  57. +11 −1 src/util.ts
1 change: 1 addition & 0 deletions .github/workflows/__analyze-ref-input.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__debug-artifacts.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__extractor-ram-threads.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__go-custom-queries.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__go-custom-tracing-autobuild.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__go-custom-tracing.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__javascript-source-root.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__multi-language-autodetect.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__packaging-config-inputs-js.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__packaging-config-js.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__packaging-inputs-js.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__remote-config.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__rubocop-multi-language.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__split-workflow.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__test-local-codeql.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__test-proxy.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__test-ruby.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__unset-environment.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/__upload-ref-sha-input.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/check-expected-release-files.yml
Original file line number Diff line number Diff line change
@@ -20,6 +20,6 @@ jobs:
run: |
bundle_version="$(cat "./src/defaults.json" | jq -r ".bundleVersion")"
set -x
for expected_file in "codeql-bundle.tar.gz" "codeql-bundle-linux64.tar.gz" "codeql-bundle-osx64.tar.gz" "codeql-bundle-win64.tar.gz" "codeql-runner-linux" "codeql-runner-macos" "codeql-runner-win.exe"; do
for expected_file in "codeql-bundle.tar.gz" "codeql-bundle-linux64.tar.gz" "codeql-bundle-osx64.tar.gz" "codeql-bundle-win64.tar.gz"; do
curl --location --fail --head --request GET "https://github.com/github/codeql-action/releases/download/$bundle_version/$expected_file" > /dev/null
done
16 changes: 16 additions & 0 deletions .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@ jobs:
lint-js:
name: Lint
runs-on: ubuntu-latest
timeout-minutes: 30

steps:
- uses: actions/checkout@v2
@@ -21,6 +22,7 @@ jobs:

check-js:
runs-on: ubuntu-latest
timeout-minutes: 30

steps:
- uses: actions/checkout@v2
@@ -30,6 +32,7 @@ jobs:
check-node-modules:
name: Check modules up to date
runs-on: macos-latest
timeout-minutes: 30

steps:
- uses: actions/checkout@v2
@@ -39,6 +42,7 @@ jobs:
verify-pr-checks:
name: Verify PR checks up to date
runs-on: ubuntu-latest
timeout-minutes: 30

steps:
- uses: actions/checkout@v2
@@ -60,6 +64,7 @@ jobs:
matrix:
os: [ubuntu-latest, macos-latest]
runs-on: ${{ matrix.os }}
timeout-minutes: 30

steps:
- uses: actions/checkout@v2
@@ -69,6 +74,7 @@ jobs:
runner-analyze-javascript-ubuntu:
name: Runner ubuntu JS analyze
needs: [check-js, check-node-modules]
timeout-minutes: 30
runs-on: ubuntu-latest

steps:
@@ -97,6 +103,7 @@ jobs:
runner-analyze-javascript-windows:
name: Runner windows JS analyze
needs: [check-js, check-node-modules]
timeout-minutes: 30
runs-on: windows-latest

steps:
@@ -121,6 +128,7 @@ jobs:
runner-analyze-javascript-macos:
name: Runner macos JS analyze
needs: [check-js, check-node-modules]
timeout-minutes: 30
runs-on: macos-latest

steps:
@@ -145,6 +153,7 @@ jobs:
runner-analyze-csharp-ubuntu:
name: Runner ubuntu C# analyze
needs: [check-js, check-node-modules]
timeout-minutes: 30
runs-on: ubuntu-latest

steps:
@@ -184,6 +193,7 @@ jobs:
needs: [check-js, check-node-modules]
# Build tracing currently does not support Windows 2022, so use `windows-2019` instead of
# `windows-latest`.
timeout-minutes: 30
runs-on: windows-2019

steps:
@@ -228,6 +238,7 @@ jobs:

runner-analyze-csharp-macos:
name: Runner macos C# analyze
timeout-minutes: 30
needs: [check-js, check-node-modules]
runs-on: macos-latest

@@ -266,6 +277,7 @@ jobs:

runner-analyze-csharp-autobuild-ubuntu:
name: Runner ubuntu autobuild C# analyze
timeout-minutes: 30
needs: [check-js, check-node-modules]
runs-on: ubuntu-latest

@@ -301,6 +313,7 @@ jobs:
TEST_MODE: true

runner-analyze-csharp-autobuild-windows:
timeout-minutes: 30
name: Runner windows autobuild C# analyze
needs: [check-js, check-node-modules]
# Build tracing currently does not support Windows 2022, so use `windows-2019` instead of
@@ -343,6 +356,7 @@ jobs:
name: Runner macos autobuild C# analyze
needs: [check-js, check-node-modules]
runs-on: macos-latest
timeout-minutes: 30

steps:
- uses: actions/checkout@v2
@@ -380,6 +394,7 @@ jobs:
name: Runner upload sarif
needs: [check-js, check-node-modules]
runs-on: ubuntu-latest
timeout-minutes: 30

if: ${{ github.event_name != 'pull_request' || github.event.pull_request.base.repo.id == github.event.pull_request.head.repo.id }}

@@ -402,6 +417,7 @@ jobs:
name: Runner ubuntu extractor RAM and threads options
needs: [check-js, check-node-modules]
runs-on: ubuntu-latest
timeout-minutes: 30

steps:
- uses: actions/checkout@v2
1 change: 1 addition & 0 deletions .github/workflows/python-deps.yml
Original file line number Diff line number Diff line change
@@ -10,6 +10,7 @@ on:

jobs:
test-setup-python-scripts:
timeout-minutes: 30
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
1 change: 1 addition & 0 deletions .github/workflows/release-runner.yml
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@ on:

jobs:
release-runner:
timeout-minutes: 30
runs-on: ubuntu-latest
env:
RELEASE_TAG: "${{ github.event.inputs.bundle-tag }}"
1 change: 1 addition & 0 deletions .github/workflows/split.yml
Original file line number Diff line number Diff line change
@@ -26,6 +26,7 @@ on:
jobs:
build:
runs-on: ubuntu-latest
timeout-minutes: 30
env:
CLI_RELEASE: "${{ github.event.inputs.cli-release }}"
RELEASE_TAG: "${{ github.event.inputs.bundle-tag }}"
1 change: 1 addition & 0 deletions .github/workflows/update-dependencies.yml
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@ on:
jobs:
update:
name: Update dependencies
timeout-minutes: 30
runs-on: macos-latest
if: contains(github.event.pull_request.labels.*.name, 'Update dependencies') && (github.event.pull_request.head.repo.full_name == 'github/codeql-action')
steps:
1 change: 1 addition & 0 deletions .github/workflows/update-release-branch.yml
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@ on:

jobs:
update:
timeout-minutes: 30
runs-on: ubuntu-latest
if: ${{ github.repository == 'github/codeql-action' }}
steps:
Original file line number Diff line number Diff line change
@@ -6,6 +6,8 @@ on:

jobs:
update-supported-enterprise-server-versions:
name: Update Supported Enterprise Server Versions
timeout-minutes: 30
runs-on: ubuntu-latest
if: ${{ github.repository == 'github/codeql-action' }}

10 changes: 9 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
# CodeQL Action and CodeQL Runner Changelog
# CodeQL Action Changelog

## 1.1.5 - 15 Mar 2022

- Update default CodeQL bundle version to 2.8.3.
- The CodeQL runner is now deprecated and no longer being released. For more information, see [CodeQL runner deprecation](https://github.blog/changelog/2021-09-21-codeql-runner-deprecation/).
- Fix two bugs that cause action failures with GHES 3.3 or earlier. [#978](https://github.com/github/codeql-action/pull/978)
- Fix `not a permitted key` invalid requests with GHES 3.1 or earlier
- Fix `RUNNER_ARCH environment variable must be set` errors with GHES 3.3 or earlier

## 1.1.4 - 07 Mar 2022

21 changes: 20 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -63,7 +63,7 @@ Here are a few things you can do that will increase the likelihood of your pull
1. The first step of releasing a new version of the `codeql-action` is running the "Update release branch" workflow.
This workflow goes through the pull requests that have been merged to `main` since the last release, creates a changelog, then opens a pull request to merge the changes since the last release into the `v1` release branch.

A release is automatically started every Monday via a scheduled run of this workflow, however you can start a release manually by triggering a run via [workflow dispatch](https://github.com/github/codeql-action/actions/workflows/update-release-branch.yml).
A release is automatically started every Monday via a scheduled run of this workflow, however you can start a release manually by triggering a run via [workflow dispatch](https://github.com/github/codeql-action/actions/workflows/update-release-branch.yml).
1. The workflow run will open a pull request titled "Merge main into v1". Mark the pull request as [ready for review](https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#marking-a-pull-request-as-ready-for-review) to trigger the PR checks.
1. Review the checklist items in the pull request description.
Once you've checked off all but the last of these, approve the PR and automerge it.
@@ -72,6 +72,25 @@ Here are a few things you can do that will increase the likelihood of your pull

Approve the mergeback PR and automerge it. Once the mergeback has been merged into main, the release is complete.

## Keeping the PR checks up to date (admin access required)

Since the `codeql-action` runs most of its testing through individual Actions workflows, there are over two hundred jobs that need to pass in order for a PR to turn green. Managing these PR checks manually is time consuming and complex. Here is a semi-automated approach.

To regenerate the PR jobs for the action:

1. From a terminal, run the following commands (replace `SHA` with the sha of the commit whose checks you want to use, typically this should be the latest from `main`):

```sh
SHA= ####
CHECKS="$(gh api repos/github/codeql-action/commits/${SHA}/check-runs --paginate | jq --slurp --compact-output --raw-output '[.[].check_runs | .[].name | select(contains("https://") or . == "CodeQL" or . == "LGTM.com" or . == "Update dependencies" or . == "Update Supported Enterprise Server Versions" | not)]')"
echo "{\"contexts\": ${CHECKS}}" > checks.json
gh api -X "PATCH" repos/github/codeql-action/branches/main/protection/required_status_checks --input checks.json
gh api -X "PATCH" repos/github/codeql-action/branches/v1/protection/required_status_checks --input checks.json
````

2. Go to the [branch protection rules settings page](https://github.com/github/codeql-action/settings/branches) and validate that the rules have been updated.


## Resources

- [How to Contribute to Open Source](https://opensource.guide/how-to-contribute/)
Loading