Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive for go/incomplete-hostname-regexp and \Q #15894

Open
AlekSi opened this issue Mar 13, 2024 · 1 comment
Open

False positive for go/incomplete-hostname-regexp and \Q #15894

AlekSi opened this issue Mar 13, 2024 · 1 comment

Comments

@AlekSi
Copy link

AlekSi commented Mar 13, 2024

Description of the false positive

var todoRE = regexp.MustCompile(`^// TODO (\Qhttps://github.com/FerretDB/\E([-\w]+)/issues/(\d+))$`)

That line is annotated with: "This regular expression has an unescaped dot before 'com', so it might match more hosts than expected when the regular expression is used."

What it misses is \Q...\E escape syntax.

Code samples or links to source code

https://github.com/FerretDB/FerretDB/blob/ea9c5bda8f3f80a9263e006995d4257084a600a5/tools/checkcomments/checkcomments.go#L32

URL to the alert on GitHub code scanning (optional)

https://github.com/FerretDB/FerretDB/security/code-scanning/9

@jketema
Copy link
Contributor

jketema commented Mar 13, 2024

Hi @AlekSi,

Thank you for this false positive report. Resolving false positives is currently not a priority for us, but we hereby acknowledge the report and will track it internally for future consideration. Note that we also accept external contributions, just in case you want to have a stab at fixing this yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants