Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented pull_request_review_thread event #12295

Closed
1 task done
wolfy1339 opened this issue Nov 23, 2021 · 5 comments
Closed
1 task done

Undocumented pull_request_review_thread event #12295

wolfy1339 opened this issue Nov 23, 2021 · 5 comments
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Comments

@wolfy1339
Copy link
Contributor

wolfy1339 commented Nov 23, 2021

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads

What part(s) of the article would you like to see updated?

Add information about the new pull_request_review_thread event.

The event is currently sent when you mark a discussion on a pull request review as resolved, or unresolved.

Additional information

Example payloads can be found in octokit/webhooks#594
X-Ref: octokit/webhooks#594, octokit/webhooks#593

@wolfy1339 wolfy1339 added the content This issue or pull request belongs to the Docs Content team label Nov 23, 2021
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 23, 2021
@github-actions github-actions bot added this to Triage in Docs open source board Nov 23, 2021
@ramyaparimi ramyaparimi added waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Nov 29, 2021
@ramyaparimi
Copy link
Contributor

@wolfy1339
Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

@vgrl
Copy link
Contributor

vgrl commented Dec 22, 2021

@wolfy1339 Thank you so much for the issue and example payloads. As these changes need to be made internally, I've transferred this issue to an internal repo. I'll go ahead and close this issue now 💛

@vgrl vgrl closed this as completed Dec 22, 2021
Docs open source board automation moved this from Triage to Done Dec 22, 2021
@taisph
Copy link

taisph commented Mar 28, 2022

The title is mentioning the pull_request_review_comment but is talking about pull_request_review_thread event. The latter event is still not documented at https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads. 🤔

@MitrichDot

This comment was marked as spam.

@vgrl vgrl changed the title Undocumented pull_request_review_comment event Undocumented pull_request_review_thread event Mar 28, 2022
@vgrl
Copy link
Contributor

vgrl commented Mar 28, 2022

Thanks for pointing out that discrepancy @taisph , I'll update the title to reflect that it's the pull_request_review_thread webhook event that's undocumented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Development

No branches or pull requests

6 participants
@taisph @wolfy1339 @vgrl @ramyaparimi @MitrichDot and others