Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REST] "List requested reviewers for a pull request" does not paginate #2433

Closed
gr2m opened this issue Dec 29, 2020 · 2 comments
Closed

[REST] "List requested reviewers for a pull request" does not paginate #2433

gr2m opened this issue Dec 29, 2020 · 2 comments
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team rest Content related to rest - overview.

Comments

@gr2m
Copy link
Contributor

gr2m commented Dec 29, 2020

Follow up to https://github.com/octokit/rest.js/issues/1978 /cc @nikclayton-dfinity

What article on docs.github.com is affected?

https://docs.github.com/en/free-pro-team@latest/rest/reference/pulls#list-requested-reviewers-for-a-pull-request

What part(s) of the article would you like to see updated?

Remove per_page and page parameters

Additional information

I didn't verify that the parameters do not have any effect, because it's rather hard to setup a pull request with multiple review requests without bothering anyone else. If you could check in with the API team I'd appreciate it

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 29, 2020
@github-actions github-actions bot added this to Triage in Docs open source board Dec 29, 2020
@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team and removed triage Do not begin working on this issue until triaged by the team labels Jan 4, 2021
@janiceilene janiceilene moved this from Triage to Ecosystem in Docs open source board Jan 4, 2021
@jmarlena jmarlena moved this from Ecosystem to Anyone in Docs open source board Jan 21, 2021
@felicitymay felicitymay self-assigned this Jan 26, 2021
@felicitymay
Copy link
Contributor

Hi @gr2m 👋🏻

Thanks for flagging this issue and for including the link to the detailed information in the Octokit repository. 🙇🏻‍♀️

I checked with the ecosystem API team and they agree with you. The source files for the API docs are maintained in a different repository, so I'm going to open an internal issue for this change and close this.

Docs open source board automation moved this from Anyone to Done Jan 28, 2021
@felicitymay felicitymay removed their assignment Jan 28, 2021
@gr2m
Copy link
Contributor Author

gr2m commented Apr 18, 2021

@felicitymay the docs still include the per_page and page parameters. Will these be removed eventually? I still have an open issue at octokit/rest.js#33 and I'd like to give the Octokit user an update on their question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team rest Content related to rest - overview.
Development

No branches or pull requests

3 participants