Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility for fetch-mock using proxy-pollyfill #736

Merged
merged 2 commits into from May 27, 2020

Conversation

sullivanpt
Copy link
Contributor

Fixes wheresrhys/fetch-mock#415

Details: fetch-mock wraps the Response object in an ES6 Proxy to
provide useful test harness features such as flush. However, on
ES5 browsers without fetch or Proxy support pollyfills must be used;
the proxy-pollyfill is unable to proxy an attribute unless it exists
on the object before the Proxy is created. This change ensures
Response.bodyUsed exists on the instance, while maintaining the
semantic of setting Request.bodyUsed in the constructor before
_initBody is called.

Fixes wheresrhys/fetch-mock#415

Details: fetch-mock wraps the Response object in an ES6 Proxy to
provide useful test harness features such as flush.  However, on
ES5 browsers without fetch or Proxy support pollyfills must be used;
the proxy-pollyfill is unable to proxy an attribute unless it exists
on the object before the Proxy is created.  This change ensures
Response.bodyUsed exists on the instance, while maintaining the
semantic of setting Request.bodyUsed in the constructor before
_initBody is called.
@sullivanpt
Copy link
Contributor Author

I'm not sure why this build failed. Do you need me to look into it?

@JakeChampion JakeChampion merged commit ff32363 into JakeChampion:master May 27, 2020
@sullivanpt
Copy link
Contributor Author

Thank you!

@carlosrberto
Copy link

Any plans to release this change to NPM?

@JakeChampion
Copy link
Owner

Any plans to release this change to NPM?

3.1.0 has just been released 👍

@carlosrberto
Copy link

Thanks a lot!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working in IE11
4 participants