Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add header name in case of error #880

Merged
merged 2 commits into from Dec 15, 2020
Merged

add header name in case of error #880

merged 2 commits into from Dec 15, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 14, 2020

If an invalid name for a header is provided, the library throws an error. This is correct, but in certain scenarios it can be hard to understand which header name actually causes the error.

This PR appends the name of such error to the error message

fetch.js Outdated Show resolved Hide resolved
@ghost ghost requested a review from JakeChampion December 15, 2020 10:01
@JakeChampion JakeChampion merged commit a8aa427 into JakeChampion:master Dec 15, 2020
@JakeChampion
Copy link
Owner

JakeChampion commented Feb 18, 2021

This is released in v3.6.0 -- https://github.com/github/fetch/releases/tag/v3.6.0

@Googlnew
Copy link

Googlnew commented Aug 2, 2021

اگر نام نامعتبر برای یک سرصفحه فراهم شود، کتابخانه خطا پرتاب می کند. این درست است، اما در سناریوهای خاصی می توان فهمید که کدام نام سرصفحه در واقع باعث خطا می شود.

این روابط عمومی نام چنین خطایی را به پیام خطا می فرستد

@Googlnew
Copy link

Googlnew commented Aug 2, 2021

#1006

Repository owner locked and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants