Represent non-stringified JSON request body as an [object Object] string #881
Conversation
|
I'd like to ask for help with adding a test for this. Following the existing tests as examples, I've written this test: test('converts a non-stringified json body to [object Object] string', function() {
return fetch('/request', {
method: 'post',
headers: {
'content-type': 'application/json'
},
body: {stringified: false}
})
.then(function(response) {
return response.json()
})
.then(function(request) {
assert.equal(request.data, '[object Object]')
})
})However, https://github.com/github/fetch/blob/a8aa427de0ed808ff26c0e3eb2e59c122c44488a/fetch.js#L594 Assertions on The way I've verified this fix works is by running tests in my reproduction repository that asserts the arguments of the |
| if (typeof body === 'string') { | ||
| this.headers.set('content-type', 'text/plain;charset=UTF-8') | ||
| } else if (this._bodyBlob && this._bodyBlob.type) { | ||
| this.headers.set('content-type', this._bodyBlob.type) | ||
| } else if (support.searchParams && URLSearchParams.prototype.isPrototypeOf(body)) { | ||
| this.headers.set('content-type', 'application/x-www-form-urlencoded;charset=UTF-8') | ||
| } | ||
| } else if (contentType.includes('json') && typeof this._bodyInit !== 'string') { |
There was a problem hiding this comment.
This isn't a reliable JSON request body content-type header check. Would you recommend to provide application/json; charset=UTF-8 instead?
I'm thinking that this behavior should also affect any JSON-like content-type header (i.e. application/hal+json).
|
thk sir |
| @@ -246,14 +246,20 @@ function Body() { | |||
| this._bodyText = body = Object.prototype.toString.call(body) | |||
There was a problem hiding this comment.
Alternatively, we can set this._bodyInit to equal this._bodyText in this closure. It fixes the issue, but the solution becomes less deterministic not being connected with the request's content-type. I'm not sure it would be a good idea to always reset the body to its textual counterpart, but I would appreciate some feedback.
|
This is released in v3.6.0 -- https://github.com/github/fetch/releases/tag/v3.6.0 |
Changes
Ensures
request._bodyInit(the internal representation of a request body) is always set to a[object Object]string representation of a body in case it has a non-stringified JSON body and theContent-Typeheader stating an expected JSON body.Why