Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image not found v5 #918

Closed
1 task done
nandi95 opened this issue Mar 21, 2024 · 9 comments
Closed
1 task done

Image not found v5 #918

nandi95 opened this issue Mar 21, 2024 · 9 comments
Labels
bug Something isn't working fix-upstream When the resolution is in an upstream package/library
Milestone

Comments

@nandi95
Copy link

nandi95 commented Mar 21, 2024

🔍 Is there already an issue for your problem?

  • I have checked older issues, open and closed

📝 Description

After updating to v5 from 4.6.1 using brew I constantly get an error:

Uncaught Exception:
Error: Failed to load image from path '/Applications/Gitify.app/Contents/Resources/app.asar/assets/images/tray-idleTemplate.png'
at IpcMainImpl.<anonymous> (/Applications/Gitify.app/Contents/Resources/app.asar/main.js:85:25)
at IpcMainImpl.emit (node:events:513:28)
at EventEmitter.<anonymous> (node:electron/js2c/browser_init:2:81099)
at EventEmitter.emit (node:events:513:28)

🪜 Steps To Reproduce

Update from 4.6.1 to v5 using homebrew

ℹ System Info

M1
os: latest

📸 Screenshots

Screenshot 2024-03-21 at 09 03 09
@nandi95 nandi95 added the bug Something isn't working label Mar 21, 2024
@nandi95
Copy link
Author

nandi95 commented Mar 21, 2024

It seems to work when reinstalled.

@nandi95 nandi95 closed this as completed Mar 21, 2024
@setchy
Copy link
Member

setchy commented Mar 21, 2024

Thanks for reporting @nandi95 .

I got the same error, but slightly different experience.

When updating via homebrew from 4.5.1 to v5.0.0, I got a similar prompt ~5 times. Restarting the app and it worked fine without the need to reinstall.

We'll keep our eyes out for other similar reports

@bmulholland
Copy link
Collaborator

I got the same, had to restart the app. I doubt we can fix this, would probably need a fix in the version that's already installed on your machine :)

@setchy setchy added this to the 5.1.0 milestone Mar 21, 2024
@setchy
Copy link
Member

setchy commented Mar 28, 2024

I upgraded two devices to v5.1.0 this morning. One device was a smooth upgrade, another had the same image not found prompts. relaunching the app worked. we'll need to dig a bit deeper it seems.

@setchy setchy reopened this Mar 28, 2024
@setchy setchy removed this from the 5.1.0 milestone Mar 28, 2024
@setchy
Copy link
Member

setchy commented Apr 3, 2024

The maintainers haven't seen this issue reoccur today after performing v5.2.0 upgrades. Will close this issue, but happy to reopen if/when it may reappear

@setchy setchy closed this as completed Apr 3, 2024
@setchy
Copy link
Member

setchy commented May 6, 2024

My latest working theory is this error will occur when

  • Gitify is running
  • performing a brew upgrade to update outdated casks.

Reading through the Brew cask guides, the below call-out for quit commands seems to correlate with our experience
> (does not run when uninstall is initiated by brew upgrade or brew reinstall)

@setchy
Copy link
Member

setchy commented May 7, 2024

Proposing some changes to our cask file to should help 🤞 this: Homebrew/homebrew-cask#173061

@setchy setchy added the fix-upstream When the resolution is in an upstream package/library label May 8, 2024
@setchy
Copy link
Member

setchy commented May 14, 2024

Cask changes have been merged Homebrew/homebrew-cask#173061

Will close after our next release

@setchy setchy added this to the Release 5.6.0 milestone May 14, 2024
@setchy
Copy link
Member

setchy commented May 22, 2024

Tested successfully with v5.6.0 brew cask update

@setchy setchy closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix-upstream When the resolution is in an upstream package/library
Projects
None yet
Development

No branches or pull requests

3 participants