Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about useNativeDriver option #233

Open
Odame opened this issue Dec 3, 2021 · 1 comment
Open

Warning about useNativeDriver option #233

Odame opened this issue Dec 3, 2021 · 1 comment

Comments

@Odame
Copy link

Odame commented Dec 3, 2021

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch react-native-sortable-list@0.0.24 for a project I'm working on.

There's an annoying warning that pops up each time items in the list are dragged to reorder.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-sortable-list/src/Row.js b/node_modules/react-native-sortable-list/src/Row.js
index 32718a8..21d3c5f 100644
--- a/node_modules/react-native-sortable-list/src/Row.js
+++ b/node_modules/react-native-sortable-list/src/Row.js
@@ -197,6 +197,7 @@ export default class Row extends Component {
       Animated.timing(this._animatedLocation, {
         toValue: nextLocation,
         duration: 300,
+        useNativeDriver: false,
       }).start(() => {
         this._isAnimationRunning = false;
       });

This issue body was partially generated by patch-package.

@DanielMartinezSebastian

Great, that worked for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants