-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for member_role_id #673
Comments
Hey @adam-moss - Shouldn't this be supported already since the I didn't check the code yet. Since gitlabform follows the raw parameter passing pattern, in theory it should already be supported. I'm not able to validate it. Would you be able to try? |
@adam-moss - did you get a chance to try it out yet? |
Hey apologies on the delay in replying. No, it doesn't work as the |
Thank you for verifying. I just took a quick peak at the code for project membership. Looks like "all the data" from the config is not being passed to the API like I had assumed. What's being passed to the API right now is gitlabform/gitlabform/processors/project/members_processor.py Lines 142 to 152 in f7c5922
Looking forward to the update. I guess this will only take care of adding an existing "custom role" as member. Maybe we should open a separate feature request to have gitlabform to manage the custom roles? |
Custom roles is, currently, graphql only. Do we have a vision for how that would be integrated? |
In my opinion, it makes sense that this is available via python-gitlab library. There's an open issue about it too python-gitlab/python-gitlab#1357 Of course I can't speak for that library. Hopefully maintainers of the library also agree. Even then not sure if they have the capacity to provide that option. Don't know if there's another equivalent library. The really last option I think would be to just implement it in gitlabform but my suggestion would be to create a separate project that basically builds the library and then consume it here. |
@amimas @adam-moss - I'll look at adding |
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Creation is NOT supported here - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Creation is NOT supported here - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Creation is NOT supported here - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Creation is NOT supported here - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Creation is NOT supported here - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Creation is NOT supported here - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Creation is NOT supported here - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Creation is NOT supported here - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Creation is NOT supported here - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Creation is NOT supported here - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
- Adds basic support for custom roles, by allowing Ultimate users to specify role Ids for their Members - Creation is NOT supported here - Relates to gitlabform#673 Signed-off-by: Tim Knight <tim.knight1@engineering.digital.dwp.gov.uk>
A clear and concise description of what you want to happen.
Add support for
member_role_id
in https://github.com/gitlabform/gitlabform/blob/main/gitlabform/gitlab/members.pyThis will allow for the configuration of custom roles
Thanks.
The text was updated successfully, but these errors were encountered: