Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize apache configuration #286

Open
TheQuantumPhysicist opened this issue May 6, 2016 · 1 comment
Open

Parametrize apache configuration #286

TheQuantumPhysicist opened this issue May 6, 2016 · 1 comment

Comments

@TheQuantumPhysicist
Copy link

TheQuantumPhysicist commented May 6, 2016

I think it would be great if you guys could parametrize the Apache configurations with environment variables. This will save the users the efforts to edit the Apache configuration manually.

Apache supports environment variables very well in /etc/apache2/envvars. These environment variables can be used in sites-available configuration. For example, instead of the line:

ProxyPassReverse http://YOUR_SERVER_FQDN/

You could make it:

ProxyPassReverse http://${GITLAB_YOUR_SERVER_FQDN}/

And then this can be a variable and I can update my apache configuration without worrying about readjusting the configuration manualy.

Greetings.

@axilleas
Copy link
Contributor

axilleas commented May 7, 2016

@samerafach that's a very nice proposal. We would need to:

  1. edit the Apache files accordingly and preferably add a comment about this in the header
  2. add documentation

Can you tackle this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants