Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in negated instanceof expressions #1123

Open
gorosgobe opened this issue Sep 20, 2023 · 3 comments
Open

Bugs in negated instanceof expressions #1123

gorosgobe opened this issue Sep 20, 2023 · 3 comments

Comments

@gorosgobe
Copy link

in and instanceof expressions in JS

a in obj;
a instanceof C;

can be negated by grouping them and applying the ! operator, i.e.

!(a in obj);
!(a instanceof C);

Applying the ! operator incorrectly (on the LHS operand) leads to bugs:

!a in obj; // will evaluate to false, unless obj has a "true" or "false" key
!a instanceof C; // will evaluate to false, unless C overrides instanceof with a @@hasInstance method

For more information, please see these MDN docs and the no-unsafe-negation recommended Eslint rule.

I have found several potentially problematic instances of the above bugs in your codebase:
https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/gkz/LiveScript%24+lang:javascript+/%5C%21%5B%5B:alnum:%5D%5D%2B+instanceof+%5B%5B:alnum:%5D%5D%2B/+-file:%5C.min%5C.js%24+count:all&patternType=standard&sm=1&groupBy=repo

@vendethiel
Copy link
Contributor

LS has not instance/not in composite keywords.

@gorosgobe
Copy link
Author

This has nothing to do with LS as the language, but rather with its implementation - see sourcegraph link above.

@vendethiel
Copy link
Contributor

I thought this was a compilation error (wrong level), but the source has it as-is:
https://github.com/gkz/LiveScript/blob/master/src/ast.ls#L2515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants