Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "containers" directory #72

Closed
kmjennison opened this issue Jul 21, 2020 · 0 comments · Fixed by #73
Closed

Remove "containers" directory #72

kmjennison opened this issue Jul 21, 2020 · 0 comments · Fixed by #73
Labels
code cleanliness Updating, cleaning up old code and workarounds, refactoring

Comments

@kmjennison
Copy link
Contributor

To reduce file complexity/confusion, just put pages in the "pages" directory and put page tests in a sibling directory. We originally created the containers directory to deal with this:
vercel/next.js#3728
@kmjennison kmjennison added the code cleanliness Updating, cleaning up old code and workarounds, refactoring label Jul 21, 2020
@kmjennison kmjennison mentioned this issue Jul 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanliness Updating, cleaning up old code and workarounds, refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove containers directory and move relocate pages tests gladly-team/tab-web
1 participant
@kmjennison