Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enchantment] inline should be statement not literal #240

Open
alexander-akait opened this issue Nov 12, 2018 · 3 comments
Open

[enchantment] inline should be statement not literal #240

alexander-akait opened this issue Nov 12, 2018 · 3 comments
Assignees
@alexander-akait
Labels
enhancement minor Minor issue - does not impact the parser too much (edge cases)
Milestone
3.1.0

Comments

@alexander-akait
Copy link
Collaborator

Need fix it, not high priority
@ichiriac
Copy link
Member

Can you add a sample code in order to understand a use case

@alexander-akait
Copy link
Collaborator Author

@ichiriac we extends Inline node from Literal node and Literal from Expression node, but Inline should be extends from Statement node, just internal fix

@ichiriac ichiriac added enhancement minor Minor issue - does not impact the parser too much (edge cases) labels Jan 7, 2019
@ichiriac ichiriac added this to the 3.1.0 milestone Jan 7, 2019
@ichiriac
Copy link
Member

ichiriac commented Jan 6, 2020

@evilebottnawi - do you want to change the used node, or just change inheritance ? If it may introduce breaking changes, it should be released in 3.0.0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexander-akait alexander-akait

Labels
enhancement minor Minor issue - does not impact the parser too much (edge cases)
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
2 participants
@ichiriac @alexander-akait