Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

floating point modulo #525

Open
schurhammer opened this issue Feb 20, 2024 · 5 comments · May be fixed by #582
Open

floating point modulo #525

schurhammer opened this issue Feb 20, 2024 · 5 comments · May be fixed by #582
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@schurhammer
Copy link
Contributor

schurhammer commented Feb 20, 2024 •
edited

Can we add "fmod" to the float module?
https://www.erlang.org/doc/man/math#fmod-2

The Int type has a modulo function, why not Float?
@lpil
Copy link
Member

lpil commented Feb 22, 2024

Sounds good! It should be called modulo

@lpil lpil added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 22, 2024
@metuan metuan mentioned this issue Mar 10, 2024
Closed
@dalprahcd
Copy link

Hello @lpil, can help in this issue?

@lpil
Copy link
Member

lpil commented May 5, 2024

Hello! What are you looking for help with?

@dalprahcd
Copy link

Can I try implementing the function modulo and remainder for the float type?

@lpil
Copy link
Member

lpil commented May 6, 2024

Yes please, that would be great!

@dalprahcd dalprahcd linked a pull request May 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add float.modulo dalprahcd/stdlib
3 participants
@schurhammer @lpil @dalprahcd