Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More functions for working with Sets #590

Closed
scorpi4n opened this issue May 15, 2024 · 3 comments · Fixed by #593
Closed

More functions for working with Sets #590

scorpi4n opened this issue May 15, 2024 · 3 comments · Fixed by #593

Comments

@scorpi4n
Copy link
Contributor

I find working with Sets can be somewhat limiting given the few functions for working with them in the standard library. It currently has difference, union, and intersection, but nothing like is_superset, is_subset, is_disjoint, and the like. For my use case, I was able to create the effect of a superset function, but it seems like a function that would be included in stdlib as well as the others I mentioned.

@lpil
Copy link
Member

lpil commented May 15, 2024

Sounds good!!

@scorpi4n
Copy link
Contributor Author

scorpi4n commented May 15, 2024

I can implement the functions I mentioned, is there else anything I need to do before opening a pull request?

And if I want to implement any other functions (like symmetric_difference), should I address that in this issue, a new issue, or the pull request with the aforementioned functions?

@lpil
Copy link
Member

lpil commented May 17, 2024

A PR for is_subset and is_disjoint would be great! Thank you.

Others we can have more issues for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants