Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow install source with pip/pipenv #37

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix: Allow install source with pip/pipenv #37

merged 1 commit into from
Jan 24, 2024

Conversation

glensc
Copy link
Owner

@glensc glensc commented Jan 24, 2024

Currently not installable from source because version "Uknown" does not parse.

 ✖ pip install "trakt@https://github.com/glensc/python-trakt/archive/refs/tags/3.4.26.zip#egg=trakt" 
Collecting trakt@ https://github.com/glensc/python-trakt/archive/refs/tags/3.4.26.zip#egg=trakt
  Using cached https://github.com/glensc/python-trakt/archive/refs/tags/3.4.26.zip
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [27 lines of output]
      Traceback (most recent call last):
        File "/Users/glen/Library/Caches/glen/direnv/PlexTraktSync/python-3.8/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/Users/glen/Library/Caches/glen/direnv/PlexTraktSync/python-3.8/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/Users/glen/Library/Caches/glen/direnv/PlexTraktSync/python-3.8/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/private/var/folders/f1/qj3m1q9507d2_7rnqwfgzyrm0000gp/T/pip-build-env-g683r1ck/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 325, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
        File "/private/var/folders/f1/qj3m1q9507d2_7rnqwfgzyrm0000gp/T/pip-build-env-g683r1ck/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 295, in _get_build_requires
          self.run_setup()
        File "/private/var/folders/f1/qj3m1q9507d2_7rnqwfgzyrm0000gp/T/pip-build-env-g683r1ck/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 480, in run_setup
          super(_BuildMetaLegacyBackend, self).run_setup(setup_script=setup_script)
        File "/private/var/folders/f1/qj3m1q9507d2_7rnqwfgzyrm0000gp/T/pip-build-env-g683r1ck/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 311, in run_setup
          exec(code, locals())
        File "<string>", line 18, in <module>
        File "/private/var/folders/f1/qj3m1q9507d2_7rnqwfgzyrm0000gp/T/pip-build-env-g683r1ck/overlay/lib/python3.8/site-packages/setuptools/__init__.py", line 103, in setup
          return distutils.core.setup(**attrs)
        File "/private/var/folders/f1/qj3m1q9507d2_7rnqwfgzyrm0000gp/T/pip-build-env-g683r1ck/overlay/lib/python3.8/site-packages/setuptools/_distutils/core.py", line 147, in setup
          _setup_distribution = dist = klass(attrs)
        File "/private/var/folders/f1/qj3m1q9507d2_7rnqwfgzyrm0000gp/T/pip-build-env-g683r1ck/overlay/lib/python3.8/site-packages/setuptools/dist.py", line 314, in __init__
          self.metadata.version = self._normalize_version(self.metadata.version)
        File "/private/var/folders/f1/qj3m1q9507d2_7rnqwfgzyrm0000gp/T/pip-build-env-g683r1ck/overlay/lib/python3.8/site-packages/setuptools/dist.py", line 350, in _normalize_version
          normalized = str(Version(version))
        File "/private/var/folders/f1/qj3m1q9507d2_7rnqwfgzyrm0000gp/T/pip-build-env-g683r1ck/overlay/lib/python3.8/site-packages/setuptools/_vendor/packaging/version.py", line 198, in __init__
          raise InvalidVersion(f"Invalid version: '{version}'")
      setuptools.extern.packaging.version.InvalidVersion: Invalid version: 'Unknown'

Refs:

@glensc glensc self-assigned this Jan 24, 2024
@glensc
Copy link
Owner Author

glensc commented Jan 24, 2024

Testing with pipx:

➜ pipx install --suffix=@pr 'git+https://github.com/glensc/python-pytrakt@refs/pull/37/head'
Note: Dependent package 'charset-normalizer' contains 1 apps
  - normalizer

No apps associated with package pytrakt@pr. Try again with '--include-deps' to include apps of dependent packages, which are listed above.
If you are attempting to install a library, pipx should not be used. Consider using pip or a similar tool instead.

@glensc
Copy link
Owner Author

glensc commented Jan 24, 2024

testing with pip

➜ pip install "git+https://github.com/glensc/python-pytrakt@refs/pull/37/head"            
Collecting git+https://github.com/glensc/python-pytrakt@refs/pull/37/head
  Cloning https://github.com/glensc/python-pytrakt (to revision refs/pull/37/head) to /private/var/folders/f1/qj3m1q9507d2_7rnqwfgzyrm0000gp/T/pip-req-build-fztwpa6_
  Running command git clone --filter=blob:none --quiet https://github.com/glensc/python-pytrakt /private/var/folders/f1/qj3m1q9507d2_7rnqwfgzyrm0000gp/T/pip-req-build-fztwpa6_
...
Building wheels for collected packages: pytrakt
  Building wheel for pytrakt (pyproject.toml) ... done
  Created wheel for pytrakt: filename=pytrakt-3.4.0.dev0-py3-none-any.whl size=39863 sha256=e1979981834e0e821e12eefaeaff5769c087fdee5add7b7603287da495ffb8c5
  Stored in directory: /private/var/folders/f1/qj3m1q9507d2_7rnqwfgzyrm0000gp/T/pip-ephem-wheel-cache-y4boitkf/wheels/27/a3/b6/8a3ce3104099f4f726daf4ae4d78254d07e978f175fbb5ef47
Successfully built pytrakt
➜  pip list
Package            Version
------------------ ----------
pytrakt            3.4.0.dev0

To be able to install from source without CI dependency
@glensc glensc marked this pull request as ready for review January 24, 2024 07:06
@glensc glensc merged commit f97f513 into main Jan 24, 2024
5 checks passed
@glensc glensc deleted the install-source branch January 24, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant