Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add PublicList class #43

Merged
merged 16 commits into from
Mar 9, 2024
Merged

Feature: Add PublicList class #43

merged 16 commits into from
Mar 9, 2024

Conversation

glensc
Copy link
Owner

@glensc glensc commented Feb 29, 2024

Add PublicList for:

movie_list = PublicList.load(trakt_id)
print(movie_list.description)

for m in movie_list:
  print(f"{m.rank}. {m.title}: {m.listed_at} {m.trakt}")

Actual usage example:

Tests in a separate PR:

@glensc glensc force-pushed the List-class branch 2 times, most recently from fc0b134 to 5b3a2fc Compare February 29, 2024 17:53
@glensc glensc requested a review from simonc56 February 29, 2024 17:58
@glensc glensc marked this pull request as ready for review February 29, 2024 17:58
@glensc
Copy link
Owner Author

glensc commented Feb 29, 2024

The module name where it's placed is perhaps odd:

from trakt.users import PublicList

    from trakt.users import User
E     File "/home/runner/work/python-pytrakt/python-pytrakt/trakt/users.py", line 3
E       from __future__ import annotations
E                                        ^
E   SyntaxError: future feature annotations is not defined
@glensc
Copy link
Owner Author

glensc commented Mar 6, 2024

@simonc56 any comments?

@simonc56
Copy link
Collaborator

simonc56 commented Mar 6, 2024

I didn't test.
Maybe some tests for PublicList could be helpful.

@glensc
Copy link
Owner Author

glensc commented Mar 7, 2024

@simonc56 so, no comments on code and naming?

@glensc
Copy link
Owner Author

glensc commented Mar 9, 2024

Tests in a separate PR:

@glensc glensc merged commit b741249 into main Mar 9, 2024
5 checks passed
@glensc glensc deleted the List-class branch March 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants