-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add sync.get_playback method #48
Conversation
a0f0d54
to
32b9c51
Compare
3c44a94
to
a083dae
Compare
Warning Rate Limit Exceeded@glensc has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 39 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent update introduces a new Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
a083dae
to
a3b8dd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- trakt/sync.py (2 hunks)
Additional comments not posted (2)
trakt/sync.py (2)
23-34
: Consider adding type hints for thedata
attribute in thePlaybackEntry
dataclass to improve code readability and type checking.
346-387
: Ensure proper error handling for the external call withinget_playback
. Consider wrapping the network request in a try-except block to handle potential connectivity issues or API errors gracefully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
7cb38ec
to
dfc367f
Compare
https://trakt.docs.apiary.io/#reference/sync/playback/get-playback-progress
required by:
Not implemented:
start_at
,end_at
parametersSummary by CodeRabbit