-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throws 500 error for gitlab urls returning 404s #9
Comments
GitLab.com redirects to Sign In page when not logged in: Do you have example JSON to give to 404 responses? My idea was to add more handlers specific to the content, like on the pipeline URL give some details on pipelines. but never got that implemented, and contributions aren't exactly flooding in either :) |
But what URL you tested with? Looks like it made gitlab API query and failed, so it wasn't totally 404 URL, but related to some project? As I'm thinking about the code logic, it shouldn't make API calls to routes that are not handled. |
I believe I came across this when I pasted a URL that pointed to an issue in an existing project, but then accidentally changed the number to one that didn't exist Edit: just confirmed -- yes, that does seem to trigger it So it's not so surprising that the URL isn't unfurled, but returning an unfurl response that says something about the page not existing would be helpful. At the moment, because nothing is shown at all, we thought the unfurler just wasn't working. Wasn't until I went digging into the logs and saw the 404 that i realized i'd just fat-fingered the URL :P |
Thanks for this awesome app, makes using gitlab sooo much better with slack!
Fairly minor issue, but it seems the plugin throws an error, causing a 500 to be returned, when it tries to check a gitlab URL that results in a 404:
Full traceback
The end result is that the link is just not unfurled in slack, which isn't terrible, but would maybe be nice to catch this and show some message about the link being inaccessible (and possibly wrong?)
The text was updated successfully, but these errors were encountered: