Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inadequate example config in README.adoc #201

Open
mozai opened this issue Jun 1, 2022 · 0 comments
Open

inadequate example config in README.adoc #201

mozai opened this issue Jun 1, 2022 · 0 comments

Comments

@mozai
Copy link

mozai commented Jun 1, 2022

README.adoc says "Systemd service uses following configuration file for global and collectors related configurations" with a
config file that only mentions two collectors: gluster_ps and gluster_brick , but reading the source code I found:

  • gluster_brick
  • gluster_brick_status
  • gluster_peer_counts
  • gluster_peer_info
  • gluster_ps
  • gluster_volume_counts
  • gluster_volume_heal
  • gluster_volume_profile
  • gluster_volume_status

Reading the Makefile I found it copies extras/conf/gluster-exporter.toml.sample to /usr/local/etc/gluster-exporter/gluster-exporter.toml , and that .sample file lists the above collectors. Would really help if the README.adoc mentioned that file is the example that should be used, not what's in the README.adoc.

Would also be nice if docs/metrics.adoc groups the metrics by which collector provides them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant