From 936ee5d9f2224b9d12a8387b2ea0f7788191dd4b Mon Sep 17 00:00:00 2001 From: Marco Marche Date: Tue, 15 Jun 2021 15:46:07 +0200 Subject: [PATCH] build: remove dependency on @angular/elements and custom elements polyfill We weren't using `@angular/elements` for anything and the `custom-elements` polyfill was only included because of it. --- package.json | 1 - packages.bzl | 1 - src/dev-app/BUILD.bazel | 1 - src/dev-app/example/BUILD.bazel | 1 - src/dev-app/index.html | 8 +------- src/e2e-app/BUILD.bazel | 1 - src/e2e-app/index.html | 8 -------- yarn.lock | 12 ------------ 8 files changed, 1 insertion(+), 32 deletions(-) diff --git a/package.json b/package.json index b5be98fdc..59de7e9c7 100644 --- a/package.json +++ b/package.json @@ -54,7 +54,6 @@ "@angular/common": "^12.0.0-rc.0", "@angular/compiler": "^12.0.0-rc.0", "@angular/core": "^12.0.0-rc.0", - "@angular/elements": "^12.0.0-rc.0", "@angular/forms": "^12.0.0-rc.0", "@angular/material": "^12.0.0-next.4", "@angular/platform-browser": "^12.0.0-rc.0", diff --git a/packages.bzl b/packages.bzl index 1b129e791..fb368b6e9 100755 --- a/packages.bzl +++ b/packages.bzl @@ -47,7 +47,6 @@ ANGULAR_NGCC_BUNDLES = [ ("@angular/common", ["common-http-testing.umd.js", "common-http.umd.js", "common-testing.umd.js", "common.umd.js"]), ("@angular/compiler", ["compiler-testing.umd.js"]), ("@angular/core", ["core-testing.umd.js", "core.umd.js"]), - ("@angular/elements", ["elements.umd.js"]), ("@angular/forms", ["forms.umd.js"]), ("@angular/material", ["material-autocomplete.umd.js", "material-button.umd.js", "material-button-toggle.umd.js", "material-card.umd.js", "material-checkbox.umd.js", "material-chips.umd.js", "material-core.umd.js", "material-dialog.umd.js", "material-divider.umd.js", "material-expansion.umd.js", "material-form-field.umd.js", "material-grid-list.umd.js", "material-icon.umd.js", "material-input.umd.js", "material-list.umd.js", "material-menu.umd.js", "material-paginator.umd.js", "material-progress-bar.umd.js", "material-radio.umd.js", "material-select.umd.js", "material-sidenav.umd.js", "material-slide-toggle.umd.js", "material-slider.umd.js", "material-snack-bar.umd.js", "material-sort.umd.js", "material-table.umd.js", "material-tabs.umd.js", "material-toolbar.umd.js", "material-tooltip.umd.js"]), ("@angular/platform-browser-dynamic", ["platform-browser-dynamic-testing.umd.js", "platform-browser-dynamic.umd.js"]), diff --git a/src/dev-app/BUILD.bazel b/src/dev-app/BUILD.bazel index 773302cb2..65707318a 100644 --- a/src/dev-app/BUILD.bazel +++ b/src/dev-app/BUILD.bazel @@ -63,7 +63,6 @@ filegroup( "//tools:system-rxjs-operators.js", "@npm//:node_modules/@angular/material/prebuilt-themes/indigo-pink.css", "@npm//:node_modules/@ionic/angular/css/ionic.bundle.css", - "@npm//:node_modules/@webcomponents/custom-elements/custom-elements.min.js", "@npm//:node_modules/core-js-bundle/index.js", "@npm//:node_modules/rxjs/bundles/rxjs.umd.min.js", "@npm//:node_modules/systemjs/dist/system.js", diff --git a/src/dev-app/example/BUILD.bazel b/src/dev-app/example/BUILD.bazel index 152a89a24..4a8e8b83b 100644 --- a/src/dev-app/example/BUILD.bazel +++ b/src/dev-app/example/BUILD.bazel @@ -9,7 +9,6 @@ ng_module( "//src/gngt-examples", "//src/gngt-examples/private", "@npm//@angular/cdk", - "@npm//@angular/elements", "@npm//@angular/material", ], ) diff --git a/src/dev-app/index.html b/src/dev-app/index.html index b4c665f8d..797cfa3f5 100755 --- a/src/dev-app/index.html +++ b/src/dev-app/index.html @@ -12,13 +12,7 @@ - - - + diff --git a/src/e2e-app/BUILD.bazel b/src/e2e-app/BUILD.bazel index f91da8a94..4fea2b938 100644 --- a/src/e2e-app/BUILD.bazel +++ b/src/e2e-app/BUILD.bazel @@ -30,7 +30,6 @@ ng_module( "//src/material/calendar", "@npm//@angular/common", "@npm//@angular/core", - "@npm//@angular/elements", "@npm//@angular/forms", "@npm//@angular/platform-browser", "@npm//@angular/router", diff --git a/src/e2e-app/index.html b/src/e2e-app/index.html index 027aaef6f..2b469c424 100644 --- a/src/e2e-app/index.html +++ b/src/e2e-app/index.html @@ -14,14 +14,6 @@ - - - - Loading... diff --git a/yarn.lock b/yarn.lock index 53a7e3ace..cfa0740b7 100644 --- a/yarn.lock +++ b/yarn.lock @@ -158,13 +158,6 @@ yaml "^1.10.0" yargs "^16.2.0" -"@angular/elements@^12.0.0-rc.0": - version "12.0.0-rc.0" - resolved "https://registry.yarnpkg.com/@angular/elements/-/elements-12.0.0-rc.0.tgz#c01e3a00a121e6312240e82164cd941f08d0823e" - integrity sha512-WIwMxNesgpXp12kpfsgz++7oadJ4aQhxFzreqhUnGHGCS0GECbJU8EGSuqyO4TMRP5FZJRDgETRUqysa/wNfgQ== - dependencies: - tslib "^2.1.0" - "@angular/forms@^12.0.0-rc.0": version "12.0.0-rc.0" resolved "https://registry.yarnpkg.com/@angular/forms/-/forms-12.0.0-rc.0.tgz#1a1f71be85f8ad4e41a4ef9fe5dbef3bb04a5420" @@ -2823,11 +2816,6 @@ "@typescript-eslint/types" "4.14.0" eslint-visitor-keys "^2.0.0" -"@webcomponents/custom-elements@^1.1.0": - version "1.4.3" - resolved "https://registry.yarnpkg.com/@webcomponents/custom-elements/-/custom-elements-1.4.3.tgz#1800d49f38bb4425ebfd160b50115e62776109d7" - integrity sha512-iD0YW46SreUQANGccywK/eC+gZELNHocZZrY2fGwrIlx/biQOTkAF9IohisibHbrmIHmA9pVCIdGwzfO+W0gig== - JSONStream@^1.0.4, JSONStream@^1.2.1: version "1.3.5" resolved "https://registry.yarnpkg.com/JSONStream/-/JSONStream-1.3.5.tgz#3208c1f08d3a4d99261ab64f92302bc15e111ca0"