Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: go-chi/chi
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.0.9
Choose a base ref
...
head repository: go-chi/chi
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.0.10
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Jul 13, 2023

  1. fixed small edge case in tests of v5.0.9 for older Go versions

    @pkieltyka
    pkieltyka committed Jul 13, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    12e9322 View commit details

  2. v5.0.10

    @pkieltyka
    pkieltyka committed Jul 13, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    99bc99e View commit details
Showing with 8 additions and 2 deletions.
  1. +6 −0 CHANGELOG.md
  2. +2 −2 mux_test.go
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## v5.0.10 (2023-07-13)

- Fixed small edge case in tests of v5.0.9 for older Go versions
- History of changes: see https://github.com/go-chi/chi/compare/v5.0.8...v5.0.10


## v5.0.9 (2023-07-13)

- History of changes: see https://github.com/go-chi/chi/compare/v5.0.8...v5.0.9
4 changes: 2 additions & 2 deletions mux_test.go
View file
Original file line number Diff line number Diff line change
@@ -422,9 +422,9 @@ func TestMethodNotAllowed(t *testing.T) {
t.Fatal(resp.Status)
}
allowedMethods := resp.Header.Values("Allow")
if len(allowedMethods) != 2 || allowedMethods[0] != "GET" || allowedMethods[1] != "HEAD" {
if len(allowedMethods) != 2 || ((allowedMethods[0] != "GET" || allowedMethods[1] != "HEAD") &&
(allowedMethods[1] != "GET" || allowedMethods[0] != "HEAD")) {
t.Fatal("Allow header should contain 2 headers: GET, HEAD. Received: ", allowedMethods)

}
})
}