Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E08 during memory read for packet #3548

Closed
dhoizner opened this issue Nov 1, 2023 · 4 comments · Fixed by #3553
Closed

E08 during memory read for packet #3548

dhoizner opened this issue Nov 1, 2023 · 4 comments · Fixed by #3553
Labels
kind/bug

Comments

@dhoizner
Copy link

dhoizner commented Nov 1, 2023

Please answer the following before submitting your issue:

Note: Please include any substantial examples (debug session output,
stacktraces, etc) as linked gists.

If this is about source listing not showing up (or breakpoints not being
accepted) while running in a container please read our
FAQ
first.

  1. What version of Delve are you using (dlv version)?
❯ dlv version
Delve Debugger
Version: 1.21.2
Build: $Id: 98f8ab2662d926245917ade2f2bb38277315c7fc $
  1. What version of Go are you using? (go version)?
❯ go version
go version go1.21.1 darwin/amd64
  1. What operating system and processor architecture are you using?
macOS Sonoma 14.1 amd64
  1. What did you do?
    When trying to debug a test that contains a struct with a non-pointer object that has a function with a pointer receiver defined, interacting with that object causes all locals to return unreadable could not read string pointer protocol error E08 during memory read for packet.

Steps:

b TestHi:13
c
p c
  1. What did you expect to see?
    I expected to able to print values for locals.
  2. What did you see instead?
    I see all values being returned as error E08.

Log file and files to reproduce error are here.

Changing Thing to be *Thing on line 11 resolves the error.
aarzilli added a commit to aarzilli/delve that referenced this issue Nov 3, 2023
@aarzilli
proc: add regression test for issue go-delve#3548
1f7ae87 
Issue go-delve#3548 describes a bug in the compiler which was fixed by commit
505e50b. But this case wasn't covered by our current tests (obviously)
and the fix in the compiler looks accidental so it's worth adding a
test for it.
aarzilli added a commit to aarzilli/delve that referenced this issue Nov 3, 2023
@aarzilli
proc: add regression test for issue go-delve#3548
1dddf91 
Issue go-delve#3548 describes a bug in the compiler which was fixed by commit
505e50b. But this case wasn't covered by our current tests (obviously)
and the fix in the compiler looks accidental so it's worth adding a
test for it.

Fixes go-delve#3548
@aarzilli aarzilli mentioned this issue Nov 3, 2023
Merged
@aarzilli
Copy link
Member

aarzilli commented Nov 3, 2023

This is a bug in the compiler, which was fixed (I think unintentionally) by 505e50b1e34cdf6dff29615a076e26fb0780d10d in go1.22

cc @dr2chase, you might be interested in this. Do you think something should be done for go1.21, a backport seems unlikely to me.

@aarzilli
Copy link
Member

aarzilli commented Nov 3, 2023

PS. the associated pull request has a reduced reproduction for this bug: #3553

@dhoizner
Copy link
Author

dhoizner commented Nov 3, 2023

This is a bug in the compiler, which was fixed (I think unintentionally) by 505e50b1e34cdf6dff29615a076e26fb0780d10d in go1.22

cc @dr2chase, you might be interested in this. Do you think something should be done for go1.21, a backport seems unlikely to me.

thanks for digging into this @aarzilli!

aarzilli added a commit to aarzilli/delve that referenced this issue Nov 4, 2023
@aarzilli
proc: add regression test for issue go-delve#3548
13c5df3 
Issue go-delve#3548 describes a bug in the compiler which was fixed by commit
505e50b. But this case wasn't covered by our current tests (obviously)
and the fix in the compiler looks accidental so it's worth adding a
test for it.

Fixes go-delve#3548
aarzilli added a commit to aarzilli/delve that referenced this issue Nov 4, 2023
@aarzilli
proc: add regression test for issue go-delve#3548
ade3b24 
Issue go-delve#3548 describes a bug in the compiler which was fixed by commit
505e50b. But this case wasn't covered by our current tests (obviously)
and the fix in the compiler looks accidental so it's worth adding a
test for it.

Fixes go-delve#3548
derekparker pushed a commit that referenced this issue Nov 4, 2023
@aarzilli
proc: add regression test for issue #3548 (#3553)
e06a116 
Issue #3548 describes a bug in the compiler which was fixed by commit
505e50b. But this case wasn't covered by our current tests (obviously)
and the fix in the compiler looks accidental so it's worth adding a
test for it.

Fixes #3548
@PeterGerma
Copy link

This is a bug in the compiler, which was fixed (I think unintentionally) by 505e50b1e34cdf6dff29615a076e26fb0780d10d in go1.22

cc @dr2chase, you might be interested in this. Do you think something should be done for go1.21, a backport seems unlikely to me.

Same issue when on Go 1.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

proc: add regression test for issue #3548 aarzilli/delve
3 participants
@aarzilli @dhoizner @PeterGerma