utils: add Walk function to walk over a filesystem #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuadros
changed the title
mcuadros
requested changes
Jun 3, 2021
util/walk_test.go
Outdated
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "io/fs" |
There was a problem hiding this comment.
Since we usually keep compatibility to the two previous versions... can you avoid the usage of io/fs?
There was a problem hiding this comment.
sure! I will replace it with what is required
Adapted from the official filepath.Walk, this function allows to walk trough a whole filesystem and discover all its files
fs.FileInfo has been introduced in go 1.16.5: golang/go@d4da735#diff-46ea5b4a04796237678b36cd31d68f74209c90d604123f15dcc4bcb605dbc136 go-billy supports the 2 latest versions The latest version of go is currently 1.16, hence use the previous instance in os instead
|
@mcuadros very excited to see this land! Can we expect a new tagged version containing this change soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from the official filepath.Walk, this function allows to walk
trough a whole filesystem and discover all its files