Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scpLikeUrlRegExp requires / character #344

Closed
b3n4kh opened this issue Jun 25, 2021 · 2 comments
Closed

scpLikeUrlRegExp requires / character #344

b3n4kh opened this issue Jun 25, 2021 · 2 comments
Labels
stale Issues/PRs that are marked for closure due to inactivity

Comments

@b3n4kh
Copy link

b3n4kh commented Jun 25, 2021

scpLikeUrlRegExp ^(?:(?P<user>[^@]+)@)?(?P<host>[^:\s]+):(?:(?P<port>[0-9]{1,5})(?:\/|:))?(?P<path>[^\\].*\/[^\\].*)$

Requires that the url includes a / in the component. This should be optional as per rfc3986.

This prevents access URIs like git.example.com:repo.git which would be a valid git repo / scp URI.

A relevant rfc draft to consider could also be draft-ietf-secsh-scp-sftp-ssh-uri-04 which also referes to rfc3986.

This bug was newly introduced by: db0e226

Copy link

To help us keep things tidy and focus on the active tasks, we've introduced a stale bot to spot issues/PRs that haven't had any activity in a while.

This particular issue hasn't had any updates or activity in the past 90 days, so it's been labeled as 'stale'. If it remains inactive for the next 30 days, it'll be automatically closed.

We understand everyone's busy, but if this issue is still important to you, please feel free to add a comment or make an update to keep it active.

Thanks for your understanding and cooperation!

@github-actions github-actions bot added the stale Issues/PRs that are marked for closure due to inactivity label Feb 29, 2024
@pjbgf
Copy link
Member

pjbgf commented Feb 29, 2024

Closing as this was fixed by #715.

@pjbgf pjbgf closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues/PRs that are marked for closure due to inactivity
Projects
None yet
Development

No branches or pull requests

2 participants