Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"reference delta not found" while cloning / parsing the packfile #484

Closed
ZauberNerd opened this issue Mar 15, 2022 · 2 comments · Fixed by #485
Closed

"reference delta not found" while cloning / parsing the packfile #484

ZauberNerd opened this issue Mar 15, 2022 · 2 comments · Fixed by #485

Comments

@ZauberNerd
Copy link
Contributor

ZauberNerd commented Mar 15, 2022 •
edited

We have seen the reference delta not found error message while cloning a repository.

We created a minimal reproducible example: https://github.com/ZauberNerd/go-git-external-ref-thinpack

We already saw two other issues and a merged PR, mentioning this error message:

But those seem to only mention AWS CodeCommit (and we are on GHES) and even with #392 by @ga-paul-t merged, our reproducer is still able to reproduce the issue, therefore we are not sure, if it is the same issue or related in some other way.

Steps to reproduce:

  1. git clone git@github.com:ZauberNerd/go-git-external-ref-thinpack.git
  2. cd go-git-external-ref-thinpack/
  3. git submodule update --init --recursive
  4. go run main.go
@ZauberNerd ZauberNerd mentioned this issue Mar 15, 2022
Merged
ZauberNerd added a commit to ZauberNerd/go-git-fixtures that referenced this issue Mar 16, 2022
@ZauberNerd
Add packfile with a ref-delta object before base object
96d6741 
This commit adds test data for go-git/go-git#485

Note: The pack file in this commit has been specificaly crafted to act
as a small reproducible example of a packfile we have seen in the wild.
See also: go-git/go-git#484
@ZauberNerd ZauberNerd mentioned this issue Mar 16, 2022
Merged
@ajaykn
Copy link

ajaykn commented Mar 21, 2022

I am also facing the similar error reference delta not found when doing git.PlainClone,
but no issue with normal git.Clone

logged with more details: #495

@per1234
Copy link

per1234 commented Mar 22, 2022

I thought maybe an additional sample would be useful so I'll share my findings:

Using github.com/go-git/go-git/v5@v5.4.2, I unexpectedly encountered the "reference delta not found" error when using github.com/go-git/go-git/v5/git.PlainClone with the following three repositories:

After updating to github.com/go-git/go-git/v5@a5bbcd278ab1467bf9a8dfa615649b6c4d699119 or github.com/go-git/go-git/v5@c785af3f4559ebac52c42f12d17cb118aac383ad the problem was resolved for the first two, but not for https://github.com/hideakitai/Dynamixel. The error for that repository is only resolved when using the version of github.com/go-git/go-git from #485

pjbgf pushed a commit to fluxcd/go-git that referenced this issue Dec 5, 2022
@ZauberNerd @KnisterPeter @pjbgf
plumbing: resolve non-external delta references
634eaec 
In a self-contained pack file delta references might point to base
objects stored later in the file.
In this case we need to replace placeholders for external refs with the
actual base object and update the children references.

Fixes: go-git#484

Co-authored-by: Markus Wolf <mail@markus-wolf.de>
ZauberNerd added a commit to ZauberNerd/go-git-fixtures that referenced this issue Dec 6, 2022
@ZauberNerd
Add packfile with a ref-delta object before base object
16c45f9 
This commit adds test data for go-git/go-git#485

Note: The pack file in this commit has been specificaly crafted to act
as a small reproducible example of a packfile we have seen in the wild.
See also: go-git/go-git#484
ZauberNerd added a commit to ZauberNerd/go-git that referenced this issue Dec 6, 2022
@ZauberNerd @KnisterPeter
plumbing: resolve non-external delta references
13fab7b 
In a self-contained pack file delta references might point to base
objects stored later in the file.
In this case we need to replace placeholders for external refs with the
actual base object and update the children references.

Fixes: go-git#484

Co-authored-by: Markus Wolf <mail@markus-wolf.de>
rohankmr414 pushed a commit to rohankmr414/go-git that referenced this issue Jan 13, 2023
@ZauberNerd @KnisterPeter @rohankmr414
plumbing: resolve non-external delta references
28afdf1 
In a self-contained pack file delta references might point to base
objects stored later in the file.
In this case we need to replace placeholders for external refs with the
actual base object and update the children references.

Fixes: go-git#484

Co-authored-by: Markus Wolf <mail@markus-wolf.de>
Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
ZauberNerd added a commit to ZauberNerd/go-git that referenced this issue Mar 23, 2023
@ZauberNerd @KnisterPeter
plumbing: resolve non-external delta references
cdd1e55 
In a self-contained pack file delta references might point to base
objects stored later in the file.
In this case we need to replace placeholders for external refs with the
actual base object and update the children references.

Fixes: go-git#484

Co-authored-by: Markus Wolf <mail@markus-wolf.de>
oshoval added a commit to oshoval/cluster-network-addons-operator that referenced this issue May 28, 2023
@oshoval
bumper: Enable KSD auto bump
50950ac 
Since go-git/go-git#484 is fixed,
go-git can fetch repos which it couldnt before.

Signed-off-by: Or Shoval <oshoval@redhat.com>
@oshoval oshoval mentioned this issue May 28, 2023
Merged
oshoval added a commit to oshoval/cluster-network-addons-operator that referenced this issue May 28, 2023
@oshoval
bumper: Enable KSD auto bump
1c8baee 
Since go-git/go-git#484 is fixed,
go-git can fetch repos which it couldnt before.

Signed-off-by: Or Shoval <oshoval@redhat.com>
kubevirt-bot pushed a commit to kubevirt/cluster-network-addons-operator that referenced this issue May 28, 2023
@oshoval
auto bumper: Enable KSD auto bumping (#1561)
edccfff 
* go-git: Bump to v5.7.0

Signed-off-by: Or Shoval <oshoval@redhat.com>

* bumper: Enable KSD auto bump

Since go-git/go-git#484 is fixed,
go-git can fetch repos which it couldnt before.

Signed-off-by: Or Shoval <oshoval@redhat.com>

---------

Signed-off-by: Or Shoval <oshoval@redhat.com>
oshoval added a commit to oshoval/cluster-network-addons-operator that referenced this issue May 29, 2023
@oshoval
auto bumper: Enable KSD auto bumping (kubevirt#1561)
700d129 
* go-git: Bump to v5.7.0

Signed-off-by: Or Shoval <oshoval@redhat.com>

* bumper: Enable KSD auto bump

Since go-git/go-git#484 is fixed,
go-git can fetch repos which it couldnt before.

Signed-off-by: Or Shoval <oshoval@redhat.com>

---------

Signed-off-by: Or Shoval <oshoval@redhat.com>
durandj pushed a commit to durandj/go-git that referenced this issue Jul 1, 2023
@ZauberNerd @KnisterPeter @durandj
plumbing: resolve non-external delta references
9e56aa9 
In a self-contained pack file delta references might point to base
objects stored later in the file.
In this case we need to replace placeholders for external refs with the
actual base object and update the children references.

Fixes: go-git#484

Co-authored-by: Markus Wolf <mail@markus-wolf.de>
@pjbgf pjbgf mentioned this issue Mar 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

plumbing: resolve non-external delta references ZauberNerd/go-git
3 participants
@ZauberNerd @per1234 @ajaykn