GHE to public submodules fail on auth

[samimb]

Hello!

I am using go-git for cloning from a GitHub enterprise instance, I.e, not public GitHub, which is the default behavior for my code base.

These clones are authenticated with ssh keys as such:

	_, err := git.PlainClone("/opt/github/"+path, false, &git.CloneOptions{
		Auth:     publicKeys,
		URL:      url,
       RecurseSubmodules: git.DefaultSubmoduleRecursionDepth,
		Progress: os.Stdout,
	})

When one of the repos has a submodule from public GitHub and I have the setting to recursively clone, it fails based on auth. The main repository gets cloned but the submodule itself fails as it tried to auth.

Simply having conditionals to remove Auth from options based on URL would not work as it’s part of the original clone and would recursively go a level deeper.

[pjbgf]

@samimb A work around may be to pull the main repo (NoRecurseSubmodules) then pull the submodules with:

	s, err := w.Submodules()
	if err != nil {
		return err
	}
	err = s.Update(&SubmoduleUpdateOptions{
			Init: true,
			Auth:              nil,
		})
	...

Alternatively, you could propose an API change to set auth for submodules as part of CloneOptions.

[samimb]

@samimb A work around may be to pull the main repo (NoRecurseSubmodules) then pull the submodules with:

	s, err := w.Submodules()
	if err != nil {
		return err
	}
	err = s.Update(&SubmoduleUpdateOptions{
			Init: true,
			Auth:              nil,
		})
	...

Alternatively, you could propose an API change to set auth for submodules as part of CloneOptions.

Thanks, will try this as a workaround. Curious, what would happen if a repo does not have a submodule in it in this case?