New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Side by Side Image comparison link does not work for svgs #17112
Comments
@delvh Can you provide an example or reconstruct the issue on try.gitea.io or describe how to reproduce it? |
Surprisingly, I cannot anymore. |
I can reproduce the bug on
Because of the newly added svg, the js somehow gets confused and thinks "I'm already on I don't know whether that applies to other image types as well. |
Fixed by #17375 |
Gitea Version
1.15.2
Operating System
Linux
Browser Version
Firefox 92.0
Can you reproduce the bug on the Gitea demo site?
https://try.gitea.io/delvh/kanban-test/pulls/21/files
Description
The link to use side by side comparison of an existing with a changed image does not work anymore. The only way to see a side-by-side comparison is to reload the PR as then side-by-side will automatically be selected.
The cursor still appears as if you could click it.
However, when you actually click on it, nothing happens.
There is also nothing logged inside the console.
Screenshots
Not possible in this case as that would be the same as requiring proof that a package did in fact not arrive.
The text was updated successfully, but these errors were encountered: