Avoid user does not exist error when detecting schedule actions when the commit author is an external user (#30357) #30408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the commit author is an external user (go-gitea#30357)  When repo is a mirror, and commit author is an external user, then `GetUserByEmail` will return error. reproduce/test: - mirror Gitea to your instance - disable action and enable it again, this will trigger `DetectAndHandleSchedules` ps: also follow go-gitea#24706, it only fixed normal runs, not scheduled runs.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
wolfogre
approved these changes
Apr 11, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 11, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #30357 by @yp05327
When repo is a mirror, and commit author is an external user, then
GetUserByEmailwill return error.reproduce/test:
DetectAndHandleSchedulesps: also follow #24706, it only fixed normal runs, not scheduled runs.