Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.

NACK support #23

Open
cyphar opened this issue Dec 17, 2016 · 2 comments
Open

NACK support #23

cyphar opened this issue Dec 17, 2016 · 2 comments

Comments

@cyphar
Copy link

cyphar commented Dec 17, 2016

Currently we only support two states:

  1. Not accepted, where not enough LGTMs have been received.
  2. Accepted, where >n LGTMs have been received and it's good to merge.

I think we should consider having another state:

  • Rejected or NACK'd, where a maintainer has said "No" to a change. Now, this will be a bit tricky to make configurable (purely because of how hard it is to specify what the maintainence politics of a project are in code) but there should be a way to make it so that a NACK can't be overlooked by a maintainer.

WDYT?

@tboerger
Copy link
Member

Makes sense, I also like NACK for that per default

@bkcsoft
Copy link
Member

bkcsoft commented Dec 20, 2016

Like the idea, can definitively see it being abused 😆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants