New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address bar parameter splicing failed #2761
Comments
Hi, @web-xiaxia! I'm Dosu, and I'm here to help the kratos team manage their backlog. I wanted to let you know that we are marking this issue as stale. Based on my understanding, you opened the issue titled "Address bar parameter splicing failed" and asked if anyone has encountered the problem before and if it is a bug or incorrect usage. There hasn't been any further activity on this issue apart from a comment from kratos-ci-bot, which seems to be an automated translation of the issue body. Before we proceed, we would like to confirm if this issue is still relevant to the latest version of the kratos repository. If it is, please let us know by commenting on the issue. Otherwise, feel free to close the issue yourself, or the issue will be automatically closed in 7 days. Thank you for your contribution, and we appreciate your understanding. If you have any further questions or need assistance, please don't hesitate to reach out. |
This issue still affects our production code, there is a pending PR #2774 to fix. This bug affects all under_score_path_variable APIs client side dispatching, and we pathed the PR #2774 for a quick fix before, do you consider review and merge it? I wrote a demo code for a quick reproduce in latest Kratos version (v2.7.1), and when I rename the path variable |
@kratos-ci-bot Could you please review and merge PR #2774? The issue reported by @ruinshe is still affecting their production code and they have provided a demo code for reproduction. Thank you for your assistance. |
Hi, @web-xiaxia, I'm helping the Kratos team manage our backlog and am marking this issue as stale. From what I understand, the issue "Address bar parameter splicing failed" was reported by you in version v2.6.1, involving parameter splicing failure in the address bar. There has been recent activity from ruinshe, who mentioned a pending PR #2774 to fix the bug affecting production code and provided a demo for reproduction. I have requested a review and merge of the PR from kratos-ci-bot. Could you please confirm if this issue is still relevant to the latest version of the Kratos repository? If it is, please let the Kratos team know by commenting on the issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days. Thank you! |
any updates for this issue? |
我试了下main分支 问题还是存在 |
🤖 I understand that you're still experiencing the "Address bar parameter splicing failed" issue even after the merge of PR #2774. To assist you further, I would need to understand the exact nature of the issue you're facing. From the context provided, it seems like the parameter splicing in the address bar within the Kratos framework works by replacing placeholders in a URL template with values from a protobuf message. This is done in the If the issue is related to this function, it would be helpful to know the exact error message you're receiving and the conditions under which the error occurs. For example, does the error occur for all URL templates and protobuf messages, or only for specific ones? Additionally, could you provide the steps you took to reproduce the issue after the merge of PR #2774? This would help in identifying whether the issue is with the PR itself or with the way it was tested. Once I have this information, I can provide a more accurate solution to your problem. You can share this information by replying to this message or updating the original issue with the additional details. For reference, here is the EncodeURL function in the Kratos repository. Sources
|
#2774 就是修复这个问题的 修复后没有遇到 #2774中提到数组问题已由#2805解决了 |
#2774 is to fix this problem. After the fix, I did not encounter the array problem mentioned in #2774, which has been solved by #2805. |
🤖 The "Address bar parameter splicing failed" issue seems to be related to how URL parameters are encoded and decoded, particularly in the context of handling complex data structures and protobuf messages. The tests provided in To reproduce the issue after merging PR #2774, you should focus on the specific changes introduced by this PR and how they might affect the encoding and decoding processes. Given that PR #2774 was intended to fix a problem related to array handling, which was subsequently solved by #2805, it's crucial to verify if the issue persists with the latest changes. Here's a step-by-step guide to reproduce and investigate the issue:
By following these steps, you should be able to determine if the "Address bar parameter splicing failed" issue is specific to certain URL templates and protobuf messages or if it's a more general problem. Additionally, this approach will help you identify whether the issue is directly related to the changes made in PR #2774 or if it arises from how those changes were tested. Unfortunately, I don't have the specific details of the changes made in PR #2774 and #2805. If you could provide more information about these changes, it would be helpful in further understanding the issue. For reference, here is the form_test.go file in the Kratos repository. Sources
|
transport/http/binding/encode.go
测试用例已经提供了的> |
🤖 Based on the error messages and behaviors you've observed, it seems like the issue might be related to how URL parameters are parsed and used in service discovery and endpoint resolution. However, without more specific information about the exact circumstances under which these errors occur, it's difficult to pinpoint the exact cause. Regarding the changes made in PR #2774 and #2805, I'm unable to find specific details about these pull requests in the repository. If you could provide more information about the changes made in these PRs, it would be helpful in understanding their potential impact on the issue. As for the test cases in One way to narrow down the issue would be to isolate the specific URL templates and protobuf messages that are causing the problem. If the issue only occurs with certain templates or messages, it would suggest that the problem is specific to those cases. On the other hand, if the issue occurs with all templates and messages, it would suggest a more general problem. Another approach would be to examine the changes made in PR #2774 and #2805 in more detail. If the issue started occurring after these changes were merged, it would suggest that the problem is directly related to these changes. If the issue was present before these changes were merged, it would suggest that the problem is not directly related to these changes, but might be related to how these changes were tested. I hope this helps in troubleshooting the issue. If you have any more information or if there's anything else I can do to assist, please let me know. Sources
|
抱歉确实不明白您的意思,我在pr分支试了这个两个测试用例都是通过的 |
Sorry, I really don’t understand what you mean. I tried this on the pr branch and both test cases passed. |
版本 v2.6.1
方法 /transport/http/binding/encode.go:15
有人遇到过么 是bug还是我使用方式不正确
proto文件如下
The text was updated successfully, but these errors were encountered: