[Feature] consule register need suport tags[]

[techidea8]

when we use traefik as gateway
and consule as registry
the tags is very important
but now kratos just surport tag version
please suport more attribute as follow

// AgentServiceRegistration is used to register a new service
type AgentServiceRegistration struct {
	Kind              ServiceKind               `json:",omitempty"`
	ID                string                    `json:",omitempty"`
	Name              string                    `json:",omitempty"`
	Tags              []string                  `json:",omitempty"`
	Port              int                       `json:",omitempty"`
	Address           string                    `json:",omitempty"`
	SocketPath        string                    `json:",omitempty"`
	TaggedAddresses   map[string]ServiceAddress `json:",omitempty"`
	EnableTagOverride bool                      `json:",omitempty"`
	Meta              map[string]string         `json:",omitempty"`
	Weights           *AgentWeights             `json:",omitempty"`
	Check             *AgentServiceCheck
	Checks            AgentServiceChecks
	Proxy             *AgentServiceConnectProxyConfig `json:",omitempty"`
	Connect           *AgentServiceConnect            `json:",omitempty"`
	Namespace         string                          `json:",omitempty" bexpr:"-" hash:"ignore"`
	Partition         string                          `json:",omitempty" bexpr:"-" hash:"ignore"`
	Locality          *Locality                       `json:",omitempty" bexpr:"-" hash:"ignore"`
}

[dosubot]

Hey there, @techidea8! Good to see you back with more insights. 👋

Thank you for your feature request. I understand that you would like to extend the AgentServiceRegistration struct to support additional attributes, specifically the tags array, for better compatibility with Traefik gateway and Consul registry.

Currently, the Kratos framework does support the tags attribute, but it's limited to a single tag constructed from the service version. This is evident in the contrib/registry/consul/client.go file:

asr := &api.AgentServiceRegistration{
    ID:              svc.ID,
    Name:            svc.Name,
    Meta:            svc.Metadata,
    Tags:            []string{fmt.Sprintf("version=%s", svc.Version)},
    TaggedAddresses: addresses,
}

To support additional tags, you can modify the Tags field assignment in the AgentServiceRegistration struct to include more entries. For example, if you want to add custom tags or include more service-specific information, you can extend the Tags slice with additional strings. Here's a hypothetical example of how you might modify the code to include extra tags:

// Assuming svc.Tags is a []string field that contains additional tags you want to register.
asr := &api.AgentServiceRegistration{
    ID:              svc.ID,
    Name:            svc.Name,
    Meta:            svc.Metadata,
    Tags:            append([]string{fmt.Sprintf("version=%s", svc.Version)}, svc.Tags...),
    TaggedAddresses: addresses,
}

In this example, svc.Tags is assumed to be a slice of strings that contains additional tags you wish to register with Consul. This approach allows you to dynamically add as many tags as needed to the service registration, improving compatibility and integration capabilities with tools like Traefik that can utilize these tags for routing, service discovery, and configuration purposes.

Remember, for this approach to work, you would need to ensure that the registry.ServiceInstance struct (or whichever struct svc is an instance of) includes a Tags field or some mechanism to specify additional tags. This might require modifications to the service instance struct and any related logic for populating or passing these tags through the system.

I hope this helps! If you have any further questions or need more clarification, please don't hesitate to ask.

Sources

• contrib/registry/consul/client.go

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

[techidea8]

I understand what your mean
in fact i support this feature using "github.com/hashicorp/consul/api"
The best way is the team of go-kratos modify kratos to support this feature
we work use devops platform like codeup
it‘s not a good idea for me to modify kratos framework
it will affect our other application