Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add NewClient method to gRPC Client #3312

Open
shenqidebaozi opened this issue Apr 30, 2024 · 3 comments · May be fixed by #3323
Open

[Feature] Add NewClient method to gRPC Client #3312

shenqidebaozi opened this issue Apr 30, 2024 · 3 comments · May be fixed by #3323
Assignees
@shenqidebaozi
Labels
feature good first issue Good for newcomers

Comments

@shenqidebaozi
Copy link
Sponsor Member

Please see the FAQ in our main README.md before submitting your issue.

What problem is the feature used to solve?

In the new version of gRPC, the NewClient method has been added, and the Dials will be discarded in the future. Therefore, it is necessary to add the NewClient method to the kratos gRPC client and discard the Dial tag.

Requirements description of the feature

References
@shenqidebaozi shenqidebaozi self-assigned this Apr 30, 2024
@shenqidebaozi shenqidebaozi added the good first issue Good for newcomers label Apr 30, 2024
@Ccheers
Copy link
Contributor

Ccheers commented May 1, 2024

assign me

@vaisakh-prod
Copy link

@shenqidebaozi I would like to give it a try

@fengyuwusong
Copy link
Contributor

I would like to do this, please assign for me.

fengyuwusong added a commit to fengyuwusong/kratos that referenced this issue May 17, 2024
@fengyuwusong
feat(transport/grpc,contrib): add NewClient method to gRPC client(go-…
9fdf284 
…kratos#3312)

* feat: update grpc v1.63.x

* feat: use NewClient method replace Dial in gRPC client

* test: update grpc client test case

* docs: update README.md
fengyuwusong added a commit to fengyuwusong/kratos that referenced this issue May 17, 2024
@fengyuwusong
feat(transport/grpc,contrib): add NewClient method to gRPC client(go-…
8f5fbce 
…kratos#3312)

* feat: update grpc v1.63.x

* feat: use NewClient method replace Dial in gRPC client

* test: update grpc client test case

* docs: update README.md
@fengyuwusong fengyuwusong linked a pull request May 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shenqidebaozi shenqidebaozi

Labels
feature good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(transport/grpc,contrib): add NewClient method to gRPC client(#3312) fengyuwusong/kratos
4 participants
@fengyuwusong @Ccheers @shenqidebaozi @vaisakh-prod