added int and []byte type to entry unmarshal #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR! May you add support for int64 as well, as the go-asn1-ber supports up to 64 bits integers. I have been thinking about using the raw bytes instead of the already generated string to avoid additional type conversions, but this might blow up the code since we don't know how many bytes one attribute has.. Maybe in the future, when adding support for more (or even custom) types we should switch to |
cpuschma
reviewed
Jun 27, 2022
added 2 commits
June 27, 2022 21:55
|
Added int64 now too. Happy to add more builtin types, just started with the ones I need myself. |
cpuschma
approved these changes
Jun 27, 2022
cpuschma
changed the title
johnweldon
approved these changes
Jun 27, 2022
inv2004
pushed a commit
to inv2004/ldap
that referenced
this pull request
Jan 17, 2023
Co-authored-by: xoc <xoc@4xoc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the ground work of #304 this PR adds two additional supported variable types: int and []byte.