Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix request timeout handling #388

Merged
merged 2 commits into from Jul 26, 2022
Merged

Fix request timeout handling #388

merged 2 commits into from Jul 26, 2022

Conversation

cpuschma
Copy link
Member

Fixes #387

johnweldon
johnweldon approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it's okay to remove the atomic access, LGTM

conn.go Outdated Show resolved Hide resolved
@cpuschma cpuschma merged commit cb504ae into go-ldap:master Jul 26, 2022
@cpuschma cpuschma deleted the fix_timeout branch July 26, 2022 19:22
@cpuschma
Copy link
Member Author

cpuschma commented Jul 26, 2022 •
edited

@johnweldon Maybe it's time to create a new tag and release? There have been quite a few changes since the last release:

  • Update test matrix to Go v1.14+
  • Support for configurable logger
  • Linter cleanup
  • Update minimum required Go version to 1.14
  • Allow NTLM authentication without a password
  • Add missing Client interface methods
  • Implement Subtree delete control type
  • feat: return referrals for modify operation
  • Add Entry Unmarshal
  • added int and []byte type to entry unmarshal
  • Update dependencies to satisfy new ntlmssp.ProcessChallenge signature
  • Add String() methods to DN and its subtypes
  • Fix request timeout handling

inv2004 pushed a commit to inv2004/ldap that referenced this pull request Jan 17, 2023
@cpuschma @inv2004
Fix request timeout handling (go-ldap#388)
45d75f5 
* Fix request timeout handling
* Ensure 64-bit alignment
@raymonstah raymonstah mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnweldon johnweldon johnweldon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go routine leak at https://github.com/go-ldap/ldap/blob/master/conn.go#L498
2 participants
@cpuschma @johnweldon