Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More validation to the AddChecker function #23

Open
quasilyte opened this issue Nov 15, 2018 · 1 comment
Open

More validation to the AddChecker function #23

quasilyte opened this issue Nov 15, 2018 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@quasilyte
Copy link
Contributor

Panic if mandatory fields are missing.
Panic if there are tag duplicates.
Malformed checkers should not be interned, there should be a big explosion at the very attempt.
@quasilyte
Copy link
Contributor Author

It can also apply sorting to the tag list after the validation.

@quasilyte quasilyte added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 15, 2018
@quasilyte quasilyte mentioned this issue Dec 2, 2018
Closed
quasilyte added a commit that referenced this issue Dec 4, 2018
@quasilyte
add more checker info validation to AddChecker
717930c 
Updates #23
Fixes #52

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
@quasilyte quasilyte mentioned this issue Dec 4, 2018
Merged
quasilyte pushed a commit that referenced this issue Dec 4, 2018
add more checker info validation to AddChecker (#55)
94975fc 
Updates #23
Fixes #52

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@quasilyte