Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add go-consistent linter into CI #58

Open
quasilyte opened this issue Dec 7, 2018 · 1 comment
Open

add go-consistent linter into CI #58

quasilyte opened this issue Dec 7, 2018 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@quasilyte
Copy link
Contributor

Run https://github.com/Quasilyte/go-consistent during CI checks.
Note that there are some warnings found by it right now:


astwalk/doc_comment_walker.go:3:1: unit import: omit parenthesis in a single-package import
astwalk/local_comment_walker.go:3:1: unit import: omit parenthesis in a single-package import
astwalk/local_def_visitor.go:3:1: unit import: omit parenthesis in a single-package import
astwalk/visitor.go:3:1: unit import: omit parenthesis in a single-package import
astwalk/walk_handler.go:3:1: unit import: omit parenthesis in a single-package import
linter/lintmain/lintmain.go:39:14: arg list parens: align `)` to a same line with last argument
linter/lintmain/lintmain.go:55:14: arg list parens: align `)` to a same line with last argument

They should be fixed along the way.

@quasilyte quasilyte added the help wanted Extra attention is needed label Dec 7, 2018
@peczenyj
Copy link

How can I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants