Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve marshal errors in middleware request body handler #362

Merged
merged 1 commit into from Sep 4, 2020
Merged

Preserve marshal errors in middleware request body handler #362

merged 1 commit into from Sep 4, 2020

Conversation

moorereason
Copy link
Contributor

Fixes #361

@codecov
Copy link

codecov bot commented Aug 3, 2020 •
edited

Codecov Report

Merging #362 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   96.18%   96.19%   +0.01%     
==========================================
  Files          10       10              
  Lines        1231     1235       +4     
==========================================
+ Hits         1184     1188       +4     
  Misses         26       26              
  Partials       21       21
Impacted Files Coverage Δ
middleware.go 91.54% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f48b77...707198c. Read the comment docs.

@moorereason moorereason marked this pull request as draft August 3, 2020 14:24
@moorereason moorereason marked this pull request as ready for review August 5, 2020 03:21
@moorereason moorereason force-pushed the issue361 branch 2 times, most recently from b166a6e to 3127f0e Compare August 5, 2020 03:29
jeevatkm
jeevatkm approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moorereason Thanks for taking care and PR.

@jeevatkm jeevatkm merged commit 84b6606 into go-resty:master Sep 4, 2020
@jeevatkm jeevatkm added this to the v2.4.0 Milestone milestone Sep 5, 2020
@moorereason moorereason deleted the issue361 branch September 26, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeevatkm jeevatkm jeevatkm approved these changes

Assignees

@moorereason moorereason

Labels
enhancement
Milestone
v2.4.0 Milestone
Development

Successfully merging this pull request may close these issues.

Missing error message when Marshal failed
2 participants
@moorereason @jeevatkm