Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in AddRetryCondition function #364

Merged
merged 2 commits into from Sep 4, 2020
Merged

fix: typo in AddRetryCondition function #364

merged 2 commits into from Sep 4, 2020

Conversation

ervitis
Copy link
Contributor

@ervitis ervitis commented Aug 12, 2020 •
edited by jeevatkm

Fix the typo in readme in AddRetryConditions function

Fixes #365

@ervitis ervitis mentioned this pull request Aug 12, 2020
Closed
@codecov
Copy link

codecov bot commented Aug 12, 2020 •
edited

Codecov Report

Merging #364 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #364   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files          10       10           
  Lines        1231     1231           
=======================================
  Hits         1184     1184           
  Misses         26       26           
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca7661a...956b59f. Read the comment docs.

jeevatkm
jeevatkm approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ervitis Thanks for correcting documentation.

@jeevatkm jeevatkm merged commit 9dc1519 into go-resty:master Sep 4, 2020
@ervitis
Copy link
Contributor Author

ervitis commented Sep 4, 2020

Thanks to you for making this awesome library!

@jeevatkm jeevatkm added this to the v2.4.0 Milestone milestone Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeevatkm jeevatkm jeevatkm approved these changes

Assignees

@ervitis ervitis

Labels
documentation
Milestone
v2.4.0 Milestone
Development

Successfully merging this pull request may close these issues.

Typo in documentation in function AddRetryCondition
2 participants
@ervitis @jeevatkm