Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix print noescape json body #544

Closed
wants to merge 3 commits into from
Closed

Conversation

neo-f
Copy link

@neo-f neo-f commented May 30, 2022

No description provided.

@jeevatkm
Copy link
Member

jeevatkm commented Mar 6, 2023

@neo-f I'm sorry for the delayed attention on the PR. Thanks for your contribution.

Do you mind providing a context of this PR?

@jeevatkm
Copy link
Member

jeevatkm commented Mar 19, 2023

@neo-f It seems this PR was not tested with the implementation. I have tried to correct it couple of times and still ran into the third one. so I'm going to close it and implement it separately. Thanks for your contribution!

  • go fmt - style issue
  • return value argument mismatch
Run go test ./... -race -coverprofile=coverage.txt -covermode=atomic
6
# github.com/go-resty/resty/v2 [github.com/go-resty/resty/v2.test]
7
./request.go:934: assignment mismatch: 1 variable but noescapeJSONMarshalIndent returns 2 values
8
FAIL	github.com/go-resty/resty/v2 [build failed]
9
FAIL
10
Error: Process completed with exit code 2.
  • value of type *bytes.Buffer) as []byte value in assignment
Run go test ./... -race -coverprofile=coverage.txt -covermode=atomic
6
# github.com/go-resty/resty/v2 [github.com/go-resty/resty/v2.test]
7
FAIL	github.com/go-resty/resty/v2 [build failed]
8
Error: ./request.go:934:24: cannot use noescapeJSONMarshalIndent(&r.Body, "", "   ") (value of type *bytes.Buffer) as []byte value in assignment
9
FAIL
10
Error: The operation was canceled.   ```

Going to forward, I would request you to the due deligence while creating a PR.

@jeevatkm jeevatkm closed this Mar 19, 2023
jeevatkm added a commit that referenced this pull request Mar 19, 2023
…false, inspired by pr #544

Signed-off-by: Jeevanandam M <jeeva@myjeeva.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants