Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change retry output to warn or debug #553

Closed
chb0github opened this issue Jun 23, 2022 · 1 comment
Closed

Change retry output to warn or debug #553

chb0github opened this issue Jun 23, 2022 · 1 comment

Comments

@chb0github
Copy link

The code for output on a retry attempt is currently an error - it's debatable if it's actually an error or not. In my case, retry is pretty typical and only when all attempts have been tried is it an error.

I propose that this code

			resp, err = r.client.execute(r)
			if err != nil {
				r.client.log.Errorf("%v, Attempt %v", err, r.Attempt)
			}

Be changed to

r.client.log.Warnf

Or

r.client.log.Debugf

So that it can be suppressed unless there is an issue and that when all attempts are tried, then it outputs an Errorf

If this is ok, I will make the change and submit a PR

@jeevatkm
Copy link
Member

@chb0github Changed to warn as part of #587 released with v2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants