Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the hijack by using layer5 proxy #395

Open
ysmood opened this issue Apr 27, 2021 · 1 comment
Open

Redesign the hijack by using layer5 proxy #395

ysmood opened this issue Apr 27, 2021 · 1 comment
Labels
enhance New feature or request
Projects

Comments

@ysmood
Copy link
Collaborator

ysmood commented Apr 27, 2021

As long as we don't use any Devtools API to do it we can make it more flexible and feature-rich.

It will resolve #185 and #61

To enable the TLS hijacking, we can use https://pkg.go.dev/github.com/go-rod/rod#Browser.IgnoreCertErrors

Related issues:

@ysmood ysmood added the enhance New feature or request label Apr 27, 2021
@polyma
Copy link

polyma commented Apr 27, 2021

+1.

HTTP CONNECT requests cannot have any of their properties modified by Chromium right now. If you are using a HTTP proxy (https://chromium.googlesource.com/chromium/src/+/HEAD/net/docs/proxy.md#http-proxy-scheme) then page.MustSetUserAgent() will do nothing on the CONNECT request. This is because Chromium doesn't allow you to modify those headers. The result will be a User-Agent like Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/90.0.4403.0 Safari/537.36, which defeats the point of user agent spoofing.

Also relevant:
https://bugs.chromium.org/p/chromium/issues/detail?id=129572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance New feature or request
Projects
No open projects
Rod
  
To do
Development

No branches or pull requests

2 participants