Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: preserve hash in URLs #315

Closed
Kosette opened this issue Aug 17, 2021 · 0 comments · Fixed by #687
Closed

Feature request: preserve hash in URLs #315

Kosette opened this issue Aug 17, 2021 · 0 comments · Fixed by #687
Labels
component:backend good first issue Good for newcomers type:enhancement New feature or request

Comments

@Kosette
Copy link

Kosette commented Aug 17, 2021

I noticed that when creating bookmarks the hash and things after will all be dropped, which causes some troubles. since "#" is used by Mega Drive to identify keys or used for anchors in html so that we jump to a specific part of webpage.

anyway, any solutions? for now i have to paste the original url in excerpt after creating a bookmark, bit annoying😥
@fmartingr fmartingr changed the title anyway to reserve hash "#" in url? Feature request: preserve hash in URLs Feb 10, 2022
@fmartingr fmartingr added the good first issue Good for newcomers label Oct 6, 2022
@arakimo arakimo mentioned this issue Jul 30, 2023
Merged
fmartingr pushed a commit that referenced this issue Aug 5, 2023
@arakimo
preserve fragment in URLs (#315) (#687)
2e1016e 
* preserve fragment in URLs (#315)

* fix: correctly handle URLs without a fragment

* simplify solution to (#315)
@fmartingr fmartingr mentioned this issue Nov 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:backend good first issue Good for newcomers type:enhancement New feature or request
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

preserve fragment in URLs (#315)
2 participants
@fmartingr @Kosette