Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save hasEbook, hasArchive, etc... in database #675

Open
Monirzadeh opened this issue Jul 23, 2023 · 2 comments
Open

Save hasEbook, hasArchive, etc... in database #675

Monirzadeh opened this issue Jul 23, 2023 · 2 comments

Comments

@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Jul 23, 2023

In this specific situation, we call directly bookmark from database. So we don't get any specific parameter from request or current run (like has. Archive or hasEbook) and we don't save that parameter on database (legacy code). This parameter defines each time you open homepage of shiori
If browser, just open /bookmark/:id/ebook file should be present to the browser regardless of request, as it should be.(just check user access).
If my explain is a little confusing, please look at this part
https://github.com/go-shiori/shiori/blob/e839b6987580b750103304258ac8385f1163de08/internal/webserver/handler-api.go#L201C1-L214C3
If it is not a concern right now, we can set resolve and decide about that in #497
if not, do you have any idea as better handle that?
Same thing happen in archive and content but it on #497 and keep commit related to feature.

Originally posted by @Monirzadeh in #623 (comment)

If users remove the file from disk manually, should we update the value in the database automatically, or it should be something just in dev mode?

@Monirzadeh Monirzadeh changed the title save hasEbook, hasArchive, etc... to database Save hasEbook, hasArchive, etc... in database Jul 23, 2023
@stale
Copy link

stale bot commented Aug 29, 2023

This issue has been automatically marked as stale because it has not had any activity for quite some time.
It will be closed if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the tag:stale label Aug 29, 2023
@Monirzadeh
Copy link
Collaborator Author

we need to keep it open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

2 participants