Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect endpoint in rename tags operation #868

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Zlendy
Copy link
Contributor

@Zlendy Zlendy commented Mar 24, 2024

fixes #867

@fmartingr fmartingr changed the title fix: use correct URL endpoint in "Rename tags" fix: incorrect endpoint in rename tags operation Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.41%. Comparing base (595cb45) to head (7cf6870).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   25.58%   27.41%   +1.82%     
==========================================
  Files          47       47              
  Lines        5628     4166    -1462     
==========================================
- Hits         1440     1142     -298     
+ Misses       3989     2825    -1164     
  Partials      199      199              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmartingr
Copy link
Member

Thank you for noticing this @Zlendy! It seems I made a typo when migrating the legacy routes from the old handlers, the old API used a mix of /api/tag and /api/tags.... Anyway, let me merge this so we can cut a patch release this week with some fixes :)

@fmartingr fmartingr merged commit 5a16690 into go-shiori:master Mar 25, 2024
10 checks passed
@Zlendy Zlendy deleted the fix/867-rename-tags branch March 25, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot rename tags in v1.6.0
2 participants