Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding an http source on https://fresco.gosptail.org an incorrect error message is displayed #61

Open
ARolek opened this issue Apr 18, 2019 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ARolek
Copy link
Member

ARolek commented Apr 18, 2019

The issue is around protocol mismatch and loading HTTP from an HTTPS domain. The error message indicates the source could not be found. It would be better to indicate to the user that the protocol is the error. Maybe you can sniff for the error and adjust the message accordingly?

@ARolek ARolek added the bug Something isn't working label Apr 18, 2019
@pnorman
Copy link

pnorman commented Apr 21, 2020

The same happens if a request is made to a tilejson resource without CORS enabled.

@justenPalmer
Copy link
Collaborator

@pnorman Was this due to the tile server not including Access-Control-Allow-Origin headers? I've had trouble sniffing the errors registered on the client and isolating this issue to present a suitable error message. If I can gather some details from you, I can take another crack at it.

@justenPalmer justenPalmer self-assigned this Apr 21, 2020
@pnorman
Copy link

pnorman commented Apr 21, 2020

I'm not sure if it was the tile server not including it or if it was the tilejson server not including it. I added it to both and it fixed the problem.

The reason I added it to this issue is this issue and the CORS issue are both cases of browser policies blocking the loading of some content and it showing up as source could not be found

@justenPalmer
Copy link
Collaborator

@pnorman got it. Thanks for contributing to this issue and I'll try to isolate the CORS error cases so I can present a better error message to the user. Side note: I'm getting ready to release a new, upgraded version of Fresco. Would you be interested in trying it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants